chrome/browser/browsing_data/conditional_cache_counting_helper_browsertest.cc - Issue 2860573004: [Offline Pages] Add cached offline page utils and show usage in settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/conditional_cache_counting_helper_browsertest.cc

Issue 2860573004: [Offline Pages] Add cached offline page utils and show usage in settings. (Closed)

Patch Set: address missed comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/cache_counter.cc ('k') | chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/conditional_cache_counting_helper_browsertest.cc

diff --git a/chrome/browser/browsing_data/conditional_cache_counting_helper_browsertest.cc b/chrome/browser/browsing_data/conditional_cache_counting_helper_browsertest.cc

index 2af4f527bb4c9ae261e52b50af67b40af2271797..de2194dffad2c49a931093433d0d13bc3038dd9d 100644

--- a/chrome/browser/browsing_data/conditional_cache_counting_helper_browsertest.cc

+++ b/chrome/browser/browsing_data/conditional_cache_counting_helper_browsertest.cc

@@ -35,7 +35,7 @@ class ConditionalCacheCountingHelperBrowserTest : public InProcessBrowserTest {

void TearDownOnMainThread() override { cache_util_.reset(); }

- void CountCallback(int64_t size, bool is_upper_limit) {

+ void CountCallback(bool is_upper_limit, int64_t size) {

// Negative values represent an unexpected error.

DCHECK(size >= 0 || size == net::ERR_ABORTED);

DCHECK_CURRENTLY_ON(BrowserThread::UI);