Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: chrome/browser/certificate_manager_model.cc

Issue 2860553002: Clean up most of the ChromeOS headers in non-ChromeOS build (Closed)
Patch Set: add name to TODO Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/certificate_manager_model.cc
diff --git a/chrome/browser/certificate_manager_model.cc b/chrome/browser/certificate_manager_model.cc
index f4cbb0f34cc6a8c314fb2e0fe18e1146dd789bec..2ae0a07b623d43698a00d19bd1321d08c88d4924 100644
--- a/chrome/browser/certificate_manager_model.cc
+++ b/chrome/browser/certificate_manager_model.cc
@@ -12,9 +12,6 @@
#include "base/stl_util.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
-#include "chrome/browser/chromeos/certificate_provider/certificate_provider.h"
-#include "chrome/browser/chromeos/certificate_provider/certificate_provider_service.h"
-#include "chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.h"
#include "chrome/browser/net/nss_context.h"
#include "chrome/browser/ui/crypto_module_password_dialog_nss.h"
#include "chrome/common/net/x509_certificate_model.h"
@@ -27,6 +24,11 @@
#include "net/cert/x509_certificate.h"
#include "ui/base/l10n/l10n_util.h"
+// TODO(wychen): should be guarded by #if defined(OS_CHROMEOS)
tfarina 2017/05/04 00:22:24 Why can't you ifdef right now?
wychen 2017/05/04 01:19:27 The types in these chromeos headers are actually u
brettw 2017/05/09 22:55:25 Can you clarify this in the comment then? This com
wychen 2017/05/10 00:08:14 Done.
+#include "chrome/browser/chromeos/certificate_provider/certificate_provider.h"
+#include "chrome/browser/chromeos/certificate_provider/certificate_provider_service.h"
+#include "chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.h"
+
using content::BrowserThread;
// CertificateManagerModel is created on the UI thread. It needs a

Powered by Google App Engine
This is Rietveld 408576698