[omnibox] Home cursor, then restore, on revert

chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Index: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
index c42d1c9bec8b0bf6cebb6d8b4acb3d2c1b65185c..f50e5aa2b21729397151b593e7bb21a91071dcc9 100644
--- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
+++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
@@ -866,8 +866,8 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, BasicTextOperations) {
   EXPECT_FALSE(omnibox_view->IsSelectAll());
   EXPECT_EQ(old_text, omnibox_view->GetText());
   omnibox_view->GetSelectionBounds(&start, &end);
-  EXPECT_EQ(old_text.size(), start);
-  EXPECT_EQ(old_text.size(), end);
+  EXPECT_EQ(0U, start);
+  EXPECT_EQ(0U, end);

[Peter Kasting, 2017/05/17 02:44:14]

Maybe before RevertAll() we should explicitly move the cursor (e.g. to position
1) and check that that cursor position is preserved.  If not that, then there
should be some other similar test in this CL, which clearly tests that the
result of reverting is neither setting the cursor to start or end but preserving
it.

Perhaps there should also be something that verifies that when the new text is
shorter, the length gets clamped.

[Kevin Bailey, 2017/05/17 03:57:52]

ack, good suggestions.

[Mark P, 2017/05/22 23:58:48]

I don't see a change after this comment.  Did you decide not to do it?

[Kevin Bailey, 2017/05/23 00:03:02]

https://codereview.chromium.org/2891653003/

[Mark P, 2017/05/23 03:59:59]

Awesome.  I love follow-through. :-)

 }
 
 // Make sure the cursor position doesn't get set past the last character of