[omnibox] Home cursor, then restore, on revert

chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdio.h>
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
@@ skipping 848 matching lines @@
   omnibox_view->GetSelectionBounds(&start, &end);
   EXPECT_EQ(0U, start);
   EXPECT_EQ(0U, end);
   EXPECT_TRUE(omnibox_view->GetText().empty());
 
   // Check if RevertAll() can set text and cursor correctly.
   omnibox_view->RevertAll();
   EXPECT_FALSE(omnibox_view->IsSelectAll());
   EXPECT_EQ(old_text, omnibox_view->GetText());
   omnibox_view->GetSelectionBounds(&start, &end);
-  EXPECT_EQ(old_text.size(), start);
-  EXPECT_EQ(old_text.size(), end);
+  EXPECT_EQ(0U, start);
+  EXPECT_EQ(0U, end);

[Peter Kasting, 2017/05/17 02:44:14]

Maybe before RevertAll() we should explicitly move the cursor (e.g. to position
1) and check that that cursor position is preserved.  If not that, then there
should be some other similar test in this CL, which clearly tests that the
result of reverting is neither setting the cursor to start or end but preserving
it.

Perhaps there should also be something that verifies that when the new text is
shorter, the length gets clamped.

[Kevin Bailey, 2017/05/17 03:57:52]

ack, good suggestions.

[Mark P, 2017/05/22 23:58:48]

I don't see a change after this comment.  Did you decide not to do it?

[Kevin Bailey, 2017/05/23 00:03:02]

https://codereview.chromium.org/2891653003/

[Mark P, 2017/05/23 03:59:59]

Awesome.  I love follow-through. :-)

 }
 
 // Make sure the cursor position doesn't get set past the last character of
 // user input text when the URL is longer than the keyword.
 // (http://crbug.com/656209)
 IN_PROC_BROWSER_TEST_F(OmniboxViewTest, FocusSearchLongUrl) {
   OmniboxView* omnibox_view = NULL;
   ASSERT_NO_FATAL_FAILURE(GetOmniboxView(&omnibox_view));
 
   ASSERT_GT(strlen(url::kAboutBlankURL), strlen(kSearchKeyword));
@@ skipping 1118 matching lines @@
 
   // Now Shift+Right should do nothing, and Shift+Left should reduce.
   // At the end, so Shift+Right should do nothing.
   ASSERT_NO_FATAL_FAILURE(SendKey(ui::VKEY_RIGHT, ui::EF_SHIFT_DOWN));
   EXPECT_EQ(2u, GetSelectionSize(omnibox_view));
 
   // And Left should reduce by one character.
   ASSERT_NO_FATAL_FAILURE(SendKey(ui::VKEY_LEFT, ui::EF_SHIFT_DOWN));
   EXPECT_EQ(1u, GetSelectionSize(omnibox_view));
 }