chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc - Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings. (Closed)

Patch Set: Fix struct traits typo. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/settings_window_observer.cc ('k') | chrome/browser/ui/views/frame/browser_frame_mus.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

diff --git a/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

index a5980d58d5ef16268e9e588e6dc8ccc70ebe262a..3097a3595d1d0b1dab4cfcf614638ff65886c413 100644

--- a/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

+++ b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

@@ -131,8 +131,6 @@ void ChromeNativeAppWindowViewsAuraAsh::InitializeWindow(

const AppWindow::CreateParams& create_params) {

ChromeNativeAppWindowViewsAura::InitializeWindow(app_window, create_params);

aura::Window* window = widget()->GetNativeWindow();

- window->SetProperty(aura::client::kAppIdKey,

- new std::string(app_window->extension_id()));

if (app_window->window_type_is_panel()) {

// Ash's ShelfWindowWatcher handles app panel windows once this type is set.

« no previous file with comments | « chrome/browser/ui/ash/launcher/settings_window_observer.cc ('k') | chrome/browser/ui/views/frame/browser_frame_mus.cc » ('j') | no next file with comments »