chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc - Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings. (Closed)

Patch Set: Fix struct traits typo. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

diff --git a/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc b/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

index 2d95133cd391663ac0c5edb51fccca22c99409bb..05042a66f5fc13227b73588d386406a477bb9ebb 100644

--- a/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

+++ b/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

@@ -90,7 +90,7 @@ class LauncherContextMenuTest : public ash::test::AshTestBase {

ash::ShelfItemType shelf_item_type,

ash::WmShelf* wm_shelf) {

ash::ShelfItem item;

- item.id = 123; // dummy id

+ item.id = ash::ShelfID("dummy id");

item.type = shelf_item_type;

return LauncherContextMenu::Create(controller(), &item, wm_shelf);

}