Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: ash/public/cpp/shelf_types.h

Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings. (Closed)
Patch Set: Fix struct traits typo. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/public/cpp/shelf_struct_traits_unittest.cc ('k') | ash/public/cpp/window_properties.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/public/cpp/shelf_types.h
diff --git a/ash/public/cpp/shelf_types.h b/ash/public/cpp/shelf_types.h
index 7f24ae401709990316f534b6029e5f3818ab9396..c32f9db6b1d45461462db210013781645d312db6 100644
--- a/ash/public/cpp/shelf_types.h
+++ b/ash/public/cpp/shelf_types.h
@@ -7,6 +7,7 @@
#include <cstdint>
+#include "ash/public/cpp/app_launch_id.h"
#include "ash/public/cpp/ash_public_export.h"
namespace ash {
@@ -89,10 +90,8 @@ enum ShelfAction {
SHELF_ACTION_APP_LIST_SHOWN,
};
-// Shelf IDs are sequential values assigned to shelf items by ShelfModel for
-// runtime use; they are not persisted across restarts of the ash environment.
-using ShelfID = uint32_t;
-const ShelfID kInvalidShelfID = 0u;
+// TODO(msw): Rename AppLaunchId to ShelfID.
+using ShelfID = AppLaunchId;
// The type of a shelf item.
enum ShelfItemType {
« no previous file with comments | « ash/public/cpp/shelf_struct_traits_unittest.cc ('k') | ash/public/cpp/window_properties.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698