Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3420)

Unified Diff: ash/metrics/user_metrics_recorder_unittest.cc

Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings. (Closed)
Patch Set: Fix struct traits typo. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/mus/window_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/metrics/user_metrics_recorder_unittest.cc
diff --git a/ash/metrics/user_metrics_recorder_unittest.cc b/ash/metrics/user_metrics_recorder_unittest.cc
index 4effbd16b720e0c4039a2e126b84f2c242a340b8..f7323bb90d0f81223f76f63a0cbc0437dd5e18d0 100644
--- a/ash/metrics/user_metrics_recorder_unittest.cc
+++ b/ash/metrics/user_metrics_recorder_unittest.cc
@@ -146,17 +146,17 @@ TEST_F(UserMetricsRecorderTest, ValuesRecordedByRecordShelfItemCounts) {
ShelfItem shelf_item;
shelf_item.type = ash::TYPE_PINNED_APP;
- shelf_item.app_launch_id = AppLaunchId("app_id_1");
+ shelf_item.id = ShelfID("app_id_1");
shelf_model->Add(shelf_item);
- shelf_item.app_launch_id = AppLaunchId("app_id_2");
+ shelf_item.id = ShelfID("app_id_2");
shelf_model->Add(shelf_item);
shelf_item.type = ash::TYPE_APP;
- shelf_item.app_launch_id = AppLaunchId("app_id_3");
+ shelf_item.id = ShelfID("app_id_3");
shelf_model->Add(shelf_item);
- shelf_item.app_launch_id = AppLaunchId("app_id_4");
+ shelf_item.id = ShelfID("app_id_4");
shelf_model->Add(shelf_item);
- shelf_item.app_launch_id = AppLaunchId("app_id_5");
+ shelf_item.id = ShelfID("app_id_5");
shelf_model->Add(shelf_item);
test_api().RecordPeriodicMetrics();
« no previous file with comments | « no previous file | ash/mus/window_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698