ash/shell/window_watcher.h - Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell/window_watcher.h

Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings. (Closed)

Patch Set: Restore AppLaunchId class via using ShelfID = AppLaunchId; cleanup. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/shell/window_watcher.h

diff --git a/ash/shell/window_watcher.h b/ash/shell/window_watcher.h

index 472e245afda848c40e8227ed9c45c95c59873bf0..9ec6b37db47e82bc8de91d5cdc11c7899dd14643 100644

--- a/ash/shell/window_watcher.h

+++ b/ash/shell/window_watcher.h

@@ -34,7 +34,7 @@ class WindowWatcher : public aura::WindowObserver,

WindowWatcher();

~WindowWatcher() override;

- aura::Window* GetWindowByID(ash::ShelfID id);

+ aura::Window* GetWindowByID(const ash::ShelfID& id);

James Cook 2017/05/04 16:38:49 nit: ash:: not needed?

msw 2017/05/04 19:05:57 Done here and in the cc file.

// aura::WindowObserver overrides:

void OnWindowAdded(aura::Window* new_window) override;