Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3314)

Unified Diff: ash/public/cpp/app_launch_id.h

Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings. (Closed)
Patch Set: Restore AppLaunchId class via using ShelfID = AppLaunchId; cleanup. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/public/cpp/app_launch_id.h
diff --git a/ash/public/cpp/app_launch_id.h b/ash/public/cpp/app_launch_id.h
index 1b080ec5534db6ea075463734286eea6eaca061c..30f184d3d36e8c9c84fe3428a49955f2c1ccbc3c 100644
--- a/ash/public/cpp/app_launch_id.h
+++ b/ash/public/cpp/app_launch_id.h
@@ -25,9 +25,15 @@ class ASH_PUBLIC_EXPORT AppLaunchId {
AppLaunchId();
~AppLaunchId();
- AppLaunchId(const AppLaunchId& app_launch_id) = default;
- AppLaunchId(AppLaunchId&& app_launch_id) = default;
+ AppLaunchId(const AppLaunchId& other) = default;
+ AppLaunchId(AppLaunchId&& other) = default;
AppLaunchId& operator=(const AppLaunchId& other) = default;
+ bool operator==(const AppLaunchId& other) const;
+ bool operator!=(const AppLaunchId& other) const;
+ bool operator<(const AppLaunchId& other) const;
+
+ // Returns true if both the application id and launch id are empty.
+ bool IsEmpty() const;
James Cook 2017/05/04 16:38:48 naming question: Should this be IsValid()? Or have
msw 2017/05/04 19:05:56 Hmm, it would be nice to invert the boolean, but I
James Cook 2017/05/04 19:45:07 OK. Please update the comment to say that empty is
msw 2017/05/04 20:39:07 Done.
const std::string& app_id() const { return app_id_; }
const std::string& launch_id() const { return launch_id_; }

Powered by Google App Engine
This is Rietveld 408576698