Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: chrome/browser/ui/ash/launcher/launcher_controller_helper.cc

Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings. (Closed)
Patch Set: Fix struct traits typo. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/ash/launcher/launcher_controller_helper.h" 5 #include "chrome/browser/ui/ash/launcher/launcher_controller_helper.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/browser_process.h" 10 #include "chrome/browser/browser_process.h"
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 if (!arc_session_manager->IsAllowed()) 162 if (!arc_session_manager->IsAllowed())
163 return false; 163 return false;
164 if (!arc::IsArcPlayStoreEnabledForProfile(profile()) && 164 if (!arc::IsArcPlayStoreEnabledForProfile(profile()) &&
165 arc::IsArcPlayStoreEnabledPreferenceManagedForProfile(profile())) 165 arc::IsArcPlayStoreEnabledPreferenceManagedForProfile(profile()))
166 return false; 166 return false;
167 } 167 }
168 168
169 return true; 169 return true;
170 } 170 }
171 171
172 void LauncherControllerHelper::LaunchApp(ash::AppLaunchId id, 172 void LauncherControllerHelper::LaunchApp(const ash::ShelfID& id,
173 ash::ShelfLaunchSource source, 173 ash::ShelfLaunchSource source,
174 int event_flags) { 174 int event_flags) {
175 const std::string& app_id = id.app_id(); 175 const std::string& app_id = id.app_id;
176 const ArcAppListPrefs* arc_prefs = GetArcAppListPrefs(); 176 const ArcAppListPrefs* arc_prefs = GetArcAppListPrefs();
177 if (arc_prefs && arc_prefs->IsRegistered(app_id)) { 177 if (arc_prefs && arc_prefs->IsRegistered(app_id)) {
178 arc::LaunchApp(profile_, app_id, event_flags); 178 arc::LaunchApp(profile_, app_id, event_flags);
179 return; 179 return;
180 } 180 }
181 181
182 // |extension| could be null when it is being unloaded for updating. 182 // |extension| could be null when it is being unloaded for updating.
183 const extensions::Extension* extension = GetExtensionByID(profile_, app_id); 183 const extensions::Extension* extension = GetExtensionByID(profile_, app_id);
184 if (!extension) 184 if (!extension)
185 return; 185 return;
(...skipping 15 matching lines...) Expand all
201 if (source != ash::LAUNCH_FROM_UNKNOWN && 201 if (source != ash::LAUNCH_FROM_UNKNOWN &&
202 app_id == extensions::kWebStoreAppId) { 202 app_id == extensions::kWebStoreAppId) {
203 // Get the corresponding source string. 203 // Get the corresponding source string.
204 std::string source_value = GetSourceFromAppListSource(source); 204 std::string source_value = GetSourceFromAppListSource(source);
205 205
206 // Set an override URL to include the source. 206 // Set an override URL to include the source.
207 GURL extension_url = extensions::AppLaunchInfo::GetFullLaunchURL(extension); 207 GURL extension_url = extensions::AppLaunchInfo::GetFullLaunchURL(extension);
208 params.override_url = net::AppendQueryParameter( 208 params.override_url = net::AppendQueryParameter(
209 extension_url, extension_urls::kWebstoreSourceField, source_value); 209 extension_url, extension_urls::kWebstoreSourceField, source_value);
210 } 210 }
211 params.launch_id = id.launch_id(); 211 params.launch_id = id.launch_id;
212 212
213 OpenApplication(params); 213 OpenApplication(params);
214 } 214 }
215 215
216 ArcAppListPrefs* LauncherControllerHelper::GetArcAppListPrefs() const { 216 ArcAppListPrefs* LauncherControllerHelper::GetArcAppListPrefs() const {
217 return ArcAppListPrefs::Get(profile_); 217 return ArcAppListPrefs::Get(profile_);
218 } 218 }
219 219
220 void LauncherControllerHelper::ExtensionEnableFlowFinished() { 220 void LauncherControllerHelper::ExtensionEnableFlowFinished() {
221 LaunchApp(ash::AppLaunchId(extension_enable_flow_->extension_id()), 221 LaunchApp(ash::ShelfID(extension_enable_flow_->extension_id()),
222 ash::LAUNCH_FROM_UNKNOWN, ui::EF_NONE); 222 ash::LAUNCH_FROM_UNKNOWN, ui::EF_NONE);
223 extension_enable_flow_.reset(); 223 extension_enable_flow_.reset();
224 } 224 }
225 225
226 void LauncherControllerHelper::ExtensionEnableFlowAborted(bool user_initiated) { 226 void LauncherControllerHelper::ExtensionEnableFlowAborted(bool user_initiated) {
227 extension_enable_flow_.reset(); 227 extension_enable_flow_.reset();
228 } 228 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698