Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: ash/shell/window_watcher_shelf_item_delegate.cc

Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings. (Closed)
Patch Set: Fix struct traits typo. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/shell/window_watcher_shelf_item_delegate.h" 5 #include "ash/shell/window_watcher_shelf_item_delegate.h"
6 6
7 #include "ash/shell/window_watcher.h" 7 #include "ash/shell/window_watcher.h"
8 #include "ash/wm/window_util.h" 8 #include "ash/wm/window_util.h"
9 #include "ui/aura/window.h" 9 #include "ui/aura/window.h"
10 10
11 namespace ash { 11 namespace ash {
12 namespace shell { 12 namespace shell {
13 13
14 WindowWatcherShelfItemDelegate::WindowWatcherShelfItemDelegate( 14 WindowWatcherShelfItemDelegate::WindowWatcherShelfItemDelegate(
15 ShelfID id, 15 ShelfID id,
16 WindowWatcher* watcher) 16 WindowWatcher* watcher)
17 : ShelfItemDelegate(AppLaunchId()), id_(id), watcher_(watcher) { 17 : ShelfItemDelegate(id), watcher_(watcher) {
18 DCHECK_NE(id_, kInvalidShelfID); 18 DCHECK(!id.IsNull());
19 DCHECK(watcher_); 19 DCHECK(watcher_);
20 } 20 }
21 21
22 WindowWatcherShelfItemDelegate::~WindowWatcherShelfItemDelegate() {} 22 WindowWatcherShelfItemDelegate::~WindowWatcherShelfItemDelegate() {}
23 23
24 void WindowWatcherShelfItemDelegate::ItemSelected( 24 void WindowWatcherShelfItemDelegate::ItemSelected(
25 std::unique_ptr<ui::Event> event, 25 std::unique_ptr<ui::Event> event,
26 int64_t display_id, 26 int64_t display_id,
27 ShelfLaunchSource source, 27 ShelfLaunchSource source,
28 const ItemSelectedCallback& callback) { 28 const ItemSelectedCallback& callback) {
29 aura::Window* window = watcher_->GetWindowByID(id_); 29 aura::Window* window = watcher_->GetWindowByID(shelf_id());
30 if (window->type() == ui::wm::WINDOW_TYPE_PANEL) 30 if (window->type() == ui::wm::WINDOW_TYPE_PANEL)
31 wm::MoveWindowToDisplay(window, display_id); 31 wm::MoveWindowToDisplay(window, display_id);
32 window->Show(); 32 window->Show();
33 wm::ActivateWindow(window); 33 wm::ActivateWindow(window);
34 callback.Run(SHELF_ACTION_WINDOW_ACTIVATED, base::nullopt); 34 callback.Run(SHELF_ACTION_WINDOW_ACTIVATED, base::nullopt);
35 } 35 }
36 36
37 void WindowWatcherShelfItemDelegate::ExecuteCommand(uint32_t command_id, 37 void WindowWatcherShelfItemDelegate::ExecuteCommand(uint32_t command_id,
38 int32_t event_flags) { 38 int32_t event_flags) {
39 // This delegate does not support showing an application menu. 39 // This delegate does not support showing an application menu.
40 NOTIMPLEMENTED(); 40 NOTIMPLEMENTED();
41 } 41 }
42 42
43 void WindowWatcherShelfItemDelegate::Close() {} 43 void WindowWatcherShelfItemDelegate::Close() {}
44 44
45 } // namespace shell 45 } // namespace shell
46 } // namespace ash 46 } // namespace ash
OLDNEW
« no previous file with comments | « ash/shell/window_watcher_shelf_item_delegate.h ('k') | ash/wm/overview/window_selector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698