chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java - Issue 2860463002: [Suggestions] Remove TreeNode.getSuggestionAt() in favor of a visitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Issue 2860463002: [Suggestions] Remove TreeNode.getSuggestionAt() in favor of a visitor. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java » ('j') | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

index 85540c7dfd12a4cb3bf70173fee29b7ce0d345b6..2f99828eddc9c6db714257fd2d2cd7970516a421 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

@@ -181,6 +181,13 @@ public class SuggestionsSection extends InnerNode {

}

@Override

+ public void visitItems(NodeVisitor visitor) {

+ for (SnippetArticle suggestion : mSuggestions) {

+ visitor.visitSuggestion(suggestion);

+ }

+ @Override

public Set<Integer> getItemDismissalGroup(int position) {

return Collections.singleton(position);

}