chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java - Issue 2860463002: [Suggestions] Remove TreeNode.getSuggestionAt() in favor of a visitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java

Issue 2860463002: [Suggestions] Remove TreeNode.getSuggestionAt() in favor of a visitor. (Closed)

Patch Set: review Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java

index d82f31335f8e2808bbd4f145a6e1d30d88228599..b4cb9396d8766ece5297bc0eba4b17f4a1595e9c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java

@@ -13,6 +13,7 @@ import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.ntp.ContextMenuManager;

import org.chromium.chrome.browser.ntp.cards.ItemViewType;

import org.chromium.chrome.browser.ntp.cards.NewTabPageViewHolder;

+import org.chromium.chrome.browser.ntp.cards.NodeVisitor;

import org.chromium.chrome.browser.ntp.cards.OptionalLeaf;

import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;

@@ -59,6 +60,11 @@ public class TileGrid extends OptionalLeaf implements TileGroup.Observer {

}

@Override

+ protected void visitOptionalItem(NodeVisitor visitor) {

+ visitor.visitTileGrid();

+ }

+ @Override

public void onTileDataChanged() {

setVisible(mTileGroup.getTiles().length != 0);

if (isVisible()) notifyItemChanged(0, new ViewHolder.UpdateTilesCallback(mTileGroup));