chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java - Issue 2860463002: [Suggestions] Remove TreeNode.getSuggestionAt() in favor of a visitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

Issue 2860463002: [Suggestions] Remove TreeNode.getSuggestionAt() in favor of a visitor. (Closed)

Patch Set: review Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItem.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

index f97baf3698b16504afd131feae0d13bc3e35c9d6..7a95b2981ca2d952979f3ccd660e40dd19477ba9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

@@ -37,7 +37,7 @@ import org.chromium.chrome.browser.widget.displaystyle.UiConfig;

* - Cards can peek above the fold if there is enough space.

* - When peeking, tapping on cards will make them request a scroll up (see

- * {@link SuggestionsRecyclerView#scrollToFirstCard()}). Tap events in non-peeking state will be

+ * {@link SuggestionsRecyclerView#interceptCardTapped}). Tap events in non-peeking state will be

* routed through {@link #onCardTapped()} for subclasses to override.

* - Cards will get some lateral margins when the viewport is sufficiently wide.