Fix PasswordsSettingsTestCase.testCopyPasswordToast

ios/chrome/browser/ui/settings/passwords_settings_egtest.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/callback.h"
 #include "base/mac/foundation_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "components/autofill/core/common/password_form.h"
@@ skipping 321 matching lines @@
   chrome_test_util::VerifyAccessibilityForCurrentScreen();
   [self tapBackArrow];
 
   [self tapBackArrow];
   [self tapDone];
   [self clearPasswordStore];
 }
 
 // Checks that attempts to copy a password provide appropriate feedback,
 // both when reauthentication succeeds and when it fails.
-// TODO(crbug.com/718043): Re-enable test.
-- (void)DISABLED_testCopyPasswordToast {
+- (void)testCopyPasswordToast {
   [self scopedEnablePasswordManagementAndViewingUI];
 
   // Saving a form is needed for using the "password details" view.
   [self saveExamplePasswordForm];
 
   [self openPasswordSettings];
 
   [[EarlGrey selectElementWithMatcher:Entry(@"https://example.com, user")]
       performAction:grey_tap()];
 
@@ skipping 12 matching lines @@
   [password_details_collection_view_controller
       setReauthenticationModule:mock_reauthentication_module];
 
   // Check the snackbar in case of successful reauthentication.
   mock_reauthentication_module.shouldSucceed = YES;
   [[EarlGrey selectElementWithMatcher:CopyPasswordButton()]
       performAction:grey_tap()];
   [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
   NSString* snackbarLabel =
       l10n_util::GetNSString(IDS_IOS_SETTINGS_PASSWORD_WAS_COPIED_MESSAGE);
+  // Tap the snackbar instead of just asserting that it is there, and wait
+  // until the tap causes it to close. Otherwise it will block the copy button
+  // for the rest of the test on small devices, and scrolling to reach the
+  // button won't work when the snackbar is up.

[lpromero, 2017/05/04 09:21:08]

Is this an action item we could solve? Scrolling on visible pieces of UI ought
to work, no? Or is the snackbar modal in some way that it prevents any
interaction with any other place on the screen?

[vabr (Chromium), 2017/05/04 11:00:04]

When I tried manually with Chrome, I was able to scroll the view under the
snackbar just fine. When I was trying with the EG test yesterday, I tried
scrolling on the PasswordDetailsCollectionViewController (which I assigned an
accessibilityID for easy matching). Scrolling on the controller worked as long
as the snackbar was not up, but with the snackbar it was broken (can't remember
now whether the controller was not interactable, or whether the scrolling just
failed).

I will have a deeper look, will probably need to find better objects to scroll
on (as trivial as that seems, it took me hours yesterday and I failed).

[lpromero, 2017/05/04 11:24:54]

To be clear, I am fine as is, I was just wondering if we should track it with a
bug or report to MDC or EarlGrey. Accessibility and VoiceOver have a concept of
isAccessibilityModal, that makes some parts of the UI unreachable with VoiceOver
when a modal is up (but still interactive without VoiceOver). I wondered if
EarlGrey was relying on VoiceOver there too and would be trapped in this case.

Please don't be blocked on this discussion that goes beyond the scope of your
CL.

   [[EarlGrey selectElementWithMatcher:grey_accessibilityLabel(snackbarLabel)]
-      assertWithMatcher:grey_notNil()];
+      performAction:grey_tap()];
+  [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
 
   // Check the snackbar in case of failed reauthentication.
   mock_reauthentication_module.shouldSucceed = NO;
   [[EarlGrey selectElementWithMatcher:CopyPasswordButton()]
       performAction:grey_tap()];
   [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
   snackbarLabel =
       l10n_util::GetNSString(IDS_IOS_SETTINGS_PASSWORD_WAS_NOT_COPIED_MESSAGE);
+  // The tap checks the existence of the snackbar and also closes it.
   [[EarlGrey selectElementWithMatcher:grey_accessibilityLabel(snackbarLabel)]
-      assertWithMatcher:grey_notNil()];
+      performAction:grey_tap()];
+  // Wait until the fade-out animation completes.
+  [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
 
   [self tapBackArrow];
   [self tapBackArrow];
   [self tapDone];
   [self clearPasswordStore];
 }
 
 // Checks that attempts to copy a username provide appropriate feedback.
 - (void)testCopyUsernameToast {
   [self scopedEnablePasswordManagementAndViewingUI];
 
   // Saving a form is needed for using the "password details" view.
   [self saveExamplePasswordForm];
 
   [self openPasswordSettings];
 
   [[EarlGrey selectElementWithMatcher:Entry(@"https://example.com, user")]
       performAction:grey_tap()];
 
   // Check the snackbar.
   [[EarlGrey selectElementWithMatcher:CopyUsernameButton()]
       performAction:grey_tap()];
   [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
   NSString* snackbarLabel =
       l10n_util::GetNSString(IDS_IOS_SETTINGS_USERNAME_WAS_COPIED_MESSAGE);
+  // The tap checks the existence of the snackbar and also closes it.
   [[EarlGrey selectElementWithMatcher:grey_accessibilityLabel(snackbarLabel)]
-      assertWithMatcher:grey_notNil()];
+      performAction:grey_tap()];
+  // Wait until the fade-out animation completes.
+  [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
 
   [self tapBackArrow];
   [self tapBackArrow];
   [self tapDone];
   [self clearPasswordStore];
 }
 
 // Checks that attempts to copy a site URL provide appropriate feedback.
 - (void)testCopySiteToast {
   [self scopedEnablePasswordManagementAndViewingUI];
 
   // Saving a form is needed for using the "password details" view.
   [self saveExamplePasswordForm];
 
   [self openPasswordSettings];
 
   [[EarlGrey selectElementWithMatcher:Entry(@"https://example.com, user")]
       performAction:grey_tap()];
 
   // Check the snackbar.
   [[EarlGrey selectElementWithMatcher:CopySiteButton()]
       performAction:grey_tap()];
   [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
   NSString* snackbarLabel =
       l10n_util::GetNSString(IDS_IOS_SETTINGS_SITE_WAS_COPIED_MESSAGE);
+  // The tap checks the existence of the snackbar and also closes it.
   [[EarlGrey selectElementWithMatcher:grey_accessibilityLabel(snackbarLabel)]
-      assertWithMatcher:grey_notNil()];
+      performAction:grey_tap()];
+  // Wait until the fade-out animation completes.
+  [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
 
   [self tapBackArrow];
   [self tapBackArrow];
   [self tapDone];
   [self clearPasswordStore];
 }
 
 @end