Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3999)

Unified Diff: chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.h

Issue 2860443002: Chromad: Create AuthPolicyCredentialsManager (Closed)
Patch Set: More addressing comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.h
diff --git a/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.h b/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.h
new file mode 100644
index 0000000000000000000000000000000000000000..a970fde7735440bf24151b4d6fbfd744e7d0b0f3
--- /dev/null
+++ b/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.h
@@ -0,0 +1,106 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_AUTHPOLICY_AUTH_POLICY_CREDENTIALS_MANAGER_H_
+#define CHROME_BROWSER_CHROMEOS_AUTHPOLICY_AUTH_POLICY_CREDENTIALS_MANAGER_H_
+
+#include "base/cancelable_callback.h"
+#include "base/memory/weak_ptr.h"
+#include "chromeos/dbus/authpolicy/active_directory_info.pb.h"
+#include "chromeos/network/network_state_handler_observer.h"
+#include "components/keyed_service/content/browser_context_keyed_service_factory.h"
+#include "components/keyed_service/core/keyed_service.h"
+#include "components/signin/core/account_id/account_id.h"
+#include "third_party/cros_system_api/dbus/service_constants.h"
+
+class Profile;
+
+namespace authpolicy {
+class ActiveDirectoryUserStatus;
+}
+
+namespace base {
+template <typename T>
+struct DefaultSingletonTraits;
+} // namespace base
+
+// A service responsible for tracking user credential status. Created for each
+// Active Directory user profile.
+class AuthPolicyCredentialsManager
+ : public KeyedService,
+ public chromeos::NetworkStateHandlerObserver {
+ public:
+ explicit AuthPolicyCredentialsManager(Profile* profile);
+ ~AuthPolicyCredentialsManager() override;
+
+ // KeyedService overrides.
+ void Shutdown() override;
+
+ // chromeos::NetworkStateHandlerObserver overrides.
+ void DefaultNetworkChanged(const chromeos::NetworkState* network) override;
+ void NetworkConnectionStateChanged(
+ const chromeos::NetworkState* network) override;
+ void OnShuttingDown() override;
+
+ private:
+ // Calls AuthPolicyClient::GetUserStatus method.
+ void GetUserStatus();
+ // See AuthPolicyClient::GetUserStatusCallback.
Thiemo Nagel 2017/05/24 10:11:05 Nit: Imho it's more readable to have a blank line
Roman Sorokin (ftl) 2017/05/26 12:03:37 Done.
+ void OnGetUserStatusCallback(
+ authpolicy::ErrorType error,
+ const authpolicy::ActiveDirectoryUserStatus& user_status);
+ // Post delayed task to call GetUserStatus in the future.
+ void ScheduleGetUserStatus();
+
+ // Add itself as network observer.
+ void StartObserveNetwork();
+ // Remove itself as network observer.
+ void StopObserveNetwork();
+
+ // Update display and given name in case it has changed.
+ void UpdateDisplayAndGivenName(
+ const authpolicy::ActiveDirectoryAccountInfo& account_info);
+
+ // Shows user notification to sign out/sign in.
+ void ShowNotification(int message_id);
+
+ // Call GetUserStatus if |network_state| is connected and the previous call
+ // failed.
+ void GetUserStatusIfConnected(const chromeos::NetworkState* network_state);
+
+ Profile* profile_;
+ AccountId account_id_;
+ std::string display_name_, given_name_;
+ bool should_call_get_status_again_ = false;
Thiemo Nagel 2017/05/24 10:11:05 The name of that bool imho doesn't do a great job
Roman Sorokin (ftl) 2017/05/26 12:03:37 Done.
+ bool was_notification_shown_ = false;
Thiemo Nagel 2017/05/24 10:11:05 Imho a single bool is not sufficient because we mi
Roman Sorokin (ftl) 2017/05/26 12:03:37 Done.
+ authpolicy::ErrorType last_error_ = authpolicy::ERROR_NONE;
+ base::CancelableClosure scheduled_get_user_status_call_;
+
+ base::WeakPtrFactory<AuthPolicyCredentialsManager> weak_factory_;
+ DISALLOW_COPY_AND_ASSIGN(AuthPolicyCredentialsManager);
+};
+
+// Singleton that owns all AuthPolicyCredentialsManagers and associates them
+// with BrowserContexts.
+class AuthPolicyCredentialsManagerFactory
+ : public BrowserContextKeyedServiceFactory {
+ public:
+ static AuthPolicyCredentialsManagerFactory* GetInstance();
+
+ static void BuildForProfileIfActiveDirectory(Profile* profile);
+
+ private:
+ friend struct base::DefaultSingletonTraits<
+ AuthPolicyCredentialsManagerFactory>;
+
+ AuthPolicyCredentialsManagerFactory();
+ ~AuthPolicyCredentialsManagerFactory() override;
+
+ KeyedService* BuildServiceInstanceFor(
+ content::BrowserContext* context) const override;
+
+ DISALLOW_COPY_AND_ASSIGN(AuthPolicyCredentialsManagerFactory);
+};
+
+#endif // CHROME_BROWSER_CHROMEOS_AUTHPOLICY_AUTH_POLICY_CREDENTIALS_MANAGER_H_

Powered by Google App Engine
This is Rietveld 408576698