Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.html

Issue 2860423002: Fix the alignment on chrome://settings/passwords (Closed)
Patch Set: tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 2 <link rel="import" href="chrome://resources/cr_elements/icons.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
4 <link rel="import" href="../focus_row_behavior.html"> 4 <link rel="import" href="../focus_row_behavior.html">
5 <link rel="import" href="../settings_shared_css.html"> 5 <link rel="import" href="../settings_shared_css.html">
6 <link rel="import" href="passwords_shared_css.html"> 6 <link rel="import" href="passwords_shared_css.html">
7 7
8 <dom-module id="password-list-item"> 8 <dom-module id="password-list-item">
9 <template> 9 <template>
10 <style include="settings-shared passwords-shared"> 10 <style include="settings-shared passwords-shared">
11 #password {
12 background-color: transparent;
13 border: none;
14 flex: 1;
15 height: 20px;
16 width: 0;
17 }
18
19 #originUrl { 11 #originUrl {
20 /* The following non-flex directives allow eliding long originUrls from 12 /* The following non-flex directives allow eliding long originUrls from
21 * the left. Forcing rtl should not cause an issue for right-to-left 13 * the left. Forcing rtl should not cause an issue for right-to-left
22 * languages in this case, since valid URL characters are restricted to 14 * languages in this case, since valid URL characters are restricted to
23 * ASCII. 15 * ASCII.
24 */ 16 */
25 direction: rtl; 17 direction: rtl;
26 display: flex; 18 display: flex;
27 } 19 }
28 </style> 20 </style>
29 <div class="list-item" focus-row-container> 21 <div class="list-item" focus-row-container>
30 <div class="website-column no-min-width" 22 <div class="website-column no-min-width"
31 title="[[item.loginPair.urls.link]]"> 23 title="[[item.loginPair.urls.link]]">
32 <a id="originUrl" target="_blank" class="selectable no-min-width" 24 <a id="originUrl" target="_blank" class="selectable no-min-width"
33 href="[[item.loginPair.urls.link]]" 25 href="[[item.loginPair.urls.link]]"
34 focus-row-control focus-type="originUrl"> 26 focus-row-control focus-type="originUrl">
35 <span class="text-elide"> 27 <span class="text-elide">
36 [[item.loginPair.urls.shown]] 28 [[item.loginPair.urls.shown]]
37 </span> 29 </span>
38 </a> 30 </a>
39 </div> 31 </div>
40 <div class="username-column selectable text-elide" 32 <div class="username-column selectable text-elide"
41 id="username">[[item.loginPair.username]]</div> 33 id="username">[[item.loginPair.username]]</div>
hcarmona 2017/05/19 17:46:32 Nit: Indenting is off, should be indented 4x
vasilii 2017/05/22 08:47:51 Done.
42 <div class="password-column text-elide"> 34 <div class="password-column">
43 <template is="dom-if" if="[[!item.federationText]]"> 35 <template is="dom-if" if="[[!item.federationText]]">
44 <!-- Password type and disabled in order to match mock. --> 36 <!-- Password type and disabled in order to match mock. -->
45 <input id="password" type="password" disabled 37 <input id="password" type="password" class="password-field text-elide"
46 value="[[getEmptyPassword_(item.numCharactersInPassword)]]"> 38 disabled value="[[getEmptyPassword_(item.numCharactersInPassword)]]">
hcarmona 2017/05/19 17:46:32 Nit: indent is off, needs to be indented 4x
vasilii 2017/05/22 08:47:52 Done.
47 </input> 39 </input>
48 </template> 40 </template>
49 <template is="dom-if" if="[[item.federationText]]"> 41 <template is="dom-if" if="[[item.federationText]]">
50 <span class="selectable text-elide"> 42 <span class="password-field selectable text-elide">
51 [[item.federationText]] 43 [[item.federationText]]
52 </span> 44 </span>
53 </template> 45 </template>
54 </div>
55 <paper-icon-button id="passwordMenu" icon="cr:more-vert" 46 <paper-icon-button id="passwordMenu" icon="cr:more-vert"
56 on-tap="onPasswordMenuTap_" title="$i18n{moreActions}" 47 on-tap="onPasswordMenuTap_" title="$i18n{moreActions}"
57 focus-row-control focus-type="passwordMenu"> 48 focus-row-control focus-type="passwordMenu">
58 </paper-icon-button> 49 </paper-icon-button>
59 </div> 50 </div>
60 </div> 51 </div>
61 </template> 52 </template>
62 <script src="password_list_item.js"></script> 53 <script src="password_list_item.js"></script>
63 </dom-module> 54 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698