Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.html

Issue 2860423002: Fix the alignment on chrome://settings/passwords (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 2 <link rel="import" href="chrome://resources/cr_elements/icons.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
4 <link rel="import" href="../focus_row_behavior.html"> 4 <link rel="import" href="../focus_row_behavior.html">
5 <link rel="import" href="../settings_shared_css.html"> 5 <link rel="import" href="../settings_shared_css.html">
6 <link rel="import" href="passwords_shared_css.html"> 6 <link rel="import" href="passwords_shared_css.html">
7 7
8 <dom-module id="password-list-item"> 8 <dom-module id="password-list-item">
9 <template> 9 <template>
10 <style include="settings-shared passwords-shared"> 10 <style include="settings-shared passwords-shared">
(...skipping 20 matching lines...) Expand all
31 title="[[item.loginPair.urls.link]]"> 31 title="[[item.loginPair.urls.link]]">
32 <a id="originUrl" target="_blank" class="selectable no-min-width" 32 <a id="originUrl" target="_blank" class="selectable no-min-width"
33 href="[[item.loginPair.urls.link]]" 33 href="[[item.loginPair.urls.link]]"
34 focus-row-control focus-type="originUrl"> 34 focus-row-control focus-type="originUrl">
35 <span class="text-elide"> 35 <span class="text-elide">
36 [[item.loginPair.urls.shown]] 36 [[item.loginPair.urls.shown]]
37 </span> 37 </span>
38 </a> 38 </a>
39 </div> 39 </div>
40 <div class="username-column selectable text-elide" 40 <div class="username-column selectable text-elide"
41 id="username">[[item.loginPair.username]]</div> 41 id="username">[[item.loginPair.username]]
hcarmona 2017/05/09 19:23:28 Let's reformat this so it's more readable: <div c
vasilii 2017/05/19 13:20:13 Done.
42 <div class="password-column text-elide">
43 <template is="dom-if" if="[[!item.federationText]]">
44 <!-- Password type and disabled in order to match mock. -->
45 <input id="password" type="password" disabled
46 value="[[getEmptyPassword_(item.numCharactersInPassword)]]">
47 </input>
48 </template>
49 <template is="dom-if" if="[[item.federationText]]">
50 <span class="selectable text-elide">
51 [[item.federationText]]
52 </span>
53 </template>
54 </div>
55 <paper-icon-button id="passwordMenu" icon="cr:more-vert"
56 on-tap="onPasswordMenuTap_" title="$i18n{moreActions}"
57 focus-row-control focus-type="passwordMenu">
58 </paper-icon-button>
59 </div> 42 </div>
43 <div class="password-column text-elide">
44 <template is="dom-if" if="[[!item.federationText]]">
45 <!-- Password type and disabled in order to match mock. -->
46 <input id="password" type="password" disabled
47 value="[[getEmptyPassword_(item.numCharactersInPassword)]]">
48 </input>
49 </template>
50 <template is="dom-if" if="[[item.federationText]]">
51 <span class="selectable text-elide">
52 [[item.federationText]]
53 </span>
54 </template>
55 </div>
hcarmona 2017/05/09 19:23:28 We can move this div so the button is inside, then
vasilii 2017/05/19 13:20:13 Done.
56 <paper-icon-button id="passwordMenu" icon="cr:more-vert"
57 on-tap="onPasswordMenuTap_" title="$i18n{moreActions}"
58 focus-row-control focus-type="passwordMenu">
59 </paper-icon-button>
60 </div> 60 </div>
61 </template> 61 </template>
62 <script src="password_list_item.js"></script> 62 <script src="password_list_item.js"></script>
63 </dom-module> 63 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698