Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2860383002: Move ChangeBuilder to analyzer_plugin (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+689 lines, -3356 lines) Patch
D pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_core.dart View 1 chunk +0 lines, -165 lines 0 comments Download
D pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_dart.dart View 1 chunk +0 lines, -271 lines 0 comments Download
D pkg/analysis_server/lib/src/utilities/change_builder_core.dart View 1 chunk +0 lines, -331 lines 0 comments Download
D pkg/analysis_server/lib/src/utilities/change_builder_dart.dart View 1 chunk +0 lines, -943 lines 0 comments Download
M pkg/analysis_server/test/src/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
D pkg/analysis_server/test/src/utilities/change_builder_core_test.dart View 1 chunk +0 lines, -348 lines 0 comments Download
D pkg/analysis_server/test/src/utilities/change_builder_dart_test.dart View 1 chunk +0 lines, -1213 lines 0 comments Download
D pkg/analysis_server/test/src/utilities/test_all.dart View 1 chunk +0 lines, -18 lines 0 comments Download
A + pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart View 5 chunks +35 lines, -36 lines 0 comments Download
A + pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_core.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer_plugin/test/src/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A + pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_core_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test.dart View 6 chunks +5 lines, -17 lines 0 comments Download
A + pkg/analyzer_plugin/test/src/utilities/change_builder/test_all.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analyzer_plugin/test/src/utilities/test_all.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A pkg/analyzer_plugin/test/support/abstract_context.dart View 1 chunk +172 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/support/mock_sdk.dart View 1 chunk +463 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 7 months ago (2017-05-05 14:49:53 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-05 14:51:10 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-05 14:52:30 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6c2023bd07cef4efbbdbd073a179a92b126b1ccc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698