Add url_java.jar, AUTHORS, LICENSE and VERSION to cronet package.

Add url_java.jar, AUTHORS, LICENSE (aggregated with third_party dependencies) and VERSION to cronet package.

BUG=354143
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272042

[mef, 2014-05-16 20:04:32]

We need those files for google3 and (I guess) open source release.

[cbentzel, 2014-05-19 19:11:01]

https://codereview.chromium.org/286033006/diff/1/components/cronet/tools/cron...
File components/cronet/tools/cronet_licenses.py (right):

https://codereview.chromium.org/286033006/diff/1/components/cronet/tools/cron...
components/cronet/tools/cronet_licenses.py:18: os.path.dirname(__file__), '..',
'..', '..'))
You may want to get an infrastructure person or someone who's written a bunch of
python in chromium to see if there's a better way to do this.

phajdan would be a great candidate, especially since he wrote licenses.py

https://codereview.chromium.org/286033006/diff/1/components/cronet/tools/cron...
components/cronet/tools/cronet_licenses.py:30: 
Nit: extra newline

https://codereview.chromium.org/286033006/diff/1/components/cronet/tools/cron...
components/cronet/tools/cronet_licenses.py:32: 
Nit: Two blank lines required before top-level definition.

http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Blank_...

There's a couple other cases like that throughout this file.

https://codereview.chromium.org/286033006/diff/1/components/cronet/tools/cron...
components/cronet/tools/cronet_licenses.py:77: if len(args) < 1:
Could just do 

if not args:
  parser.print_help()
  return 1

https://codereview.chromium.org/286033006/diff/1/components/cronet/tools/cron...
components/cronet/tools/cronet_licenses.py:85: f.write(GenerateLicense())
Probably should do the f.close() in a finally: block wrapping a try: around
GenerateLicense()

[mef, 2014-05-19 21:38:02]

Chris, thanks! Pavel, do you have any comments/suggestions?

https://codereview.chromium.org/286033006/diff/1/components/cronet/tools/cron...
File components/cronet/tools/cronet_licenses.py (right):

https://codereview.chromium.org/286033006/diff/1/components/cronet/tools/cron...
components/cronet/tools/cronet_licenses.py:18: os.path.dirname(__file__), '..',
'..', '..'))
On 2014/05/19 19:11:01, cbentzel wrote:
> You may want to get an infrastructure person or someone who's written a bunch
of
> python in chromium to see if there's a better way to do this.
> 
> phajdan would be a great candidate, especially since he wrote licenses.py
Sounds good. I've copied this pattern from webview_licenses.py. Pavel, do you
have any suggestions?

https://codereview.chromium.org/286033006/diff/1/components/cronet/tools/cron...
components/cronet/tools/cronet_licenses.py:30: 
On 2014/05/19 19:11:01, cbentzel wrote:
> Nit: extra newline

Done.

https://codereview.chromium.org/286033006/diff/1/components/cronet/tools/cron...
components/cronet/tools/cronet_licenses.py:32: 
On 2014/05/19 19:11:01, cbentzel wrote:
> Nit: Two blank lines required before top-level definition.
> 
>
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Blank_...
> 
> There's a couple other cases like that throughout this file.

Done.

https://codereview.chromium.org/286033006/diff/1/components/cronet/tools/cron...
components/cronet/tools/cronet_licenses.py:77: if len(args) < 1:
On 2014/05/19 19:11:01, cbentzel wrote:
> Could just do 
> 
> if not args:
>   parser.print_help()
>   return 1

Done.

https://codereview.chromium.org/286033006/diff/1/components/cronet/tools/cron...
components/cronet/tools/cronet_licenses.py:85: f.write(GenerateLicense())
On 2014/05/19 19:11:01, cbentzel wrote:
> Probably should do the f.close() in a finally: block wrapping a try: around
> GenerateLicense()

Done.

https://codereview.chromium.org/286033006/diff/20001/components/cronet.gypi
File components/cronet.gypi (right):

https://codereview.chromium.org/286033006/diff/20001/components/cronet.gypi#n...
components/cronet.gypi:169: '<(PRODUCT_DIR)/lib.java/url_java.jar',
I'd like to combine all these jars into one 'cronet.jar'. 
Does it make sense? 
What is a good way to do it? 
I'm just thinking about unjaring them into temp directory and rejaring into
cronet.jar. 
Is there a better way?

[Paweł Hajdan Jr., 2014-05-20 12:39:12]

LGTM

Note that the commit message does not match the code changes, please fix that.

[mmenke, 2014-05-20 16:09:20]

On 2014/05/20 12:39:12, Paweł Hajdan Jr. wrote:
> LGTM
> 
> Note that the commit message does not match the code changes, please fix that.

LGTM

[mef, 2014-05-20 22:19:38]

The CQ bit was checked by mef@chromium.org

[commit-bot: I haz the power, 2014-05-20 22:20:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mef@chromium.org/286033006/20001

[commit-bot: I haz the power, 2014-05-21 03:19:40]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)

[mef, 2014-05-21 16:43:34]

The CQ bit was checked by mef@chromium.org

[commit-bot: I haz the power, 2014-05-21 19:57:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mef@chromium.org/286033006/30001

[commit-bot: I haz the power, 2014-05-22 01:26:48]

Change committed as 272042