Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

Issue 2860293002: Change cc::ElementId to be a uint64_t (Closed)
Patch Set: none Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
index 2c13bd2e5670e4d61dc7b300b0984a205c0b8b60..ba2a5ea889f09dc130cd3b0edfa29883571b864e 100644
--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
@@ -714,8 +714,8 @@ class FakeScrollClient : public WebLayerScrollClient {
TEST_F(PaintArtifactCompositorTestWithPropertyTrees, OneScrollNode) {
FakeScrollClient scroll_client;
- CompositorElementId expected_compositor_element_id =
- CompositorElementId(2, 0);
+ CompositorElementId expected_compositor_element_id;
+ expected_compositor_element_id.id = 2;
RefPtr<TransformPaintPropertyNode> scroll_translation =
TransformPaintPropertyNode::CreateScrollTranslation(
TransformPaintPropertyNode::Root(),
@@ -823,8 +823,8 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees, NestedScrollNodes) {
RefPtr<EffectPaintPropertyNode> effect =
CreateOpacityOnlyEffect(EffectPaintPropertyNode::Root(), 0.5);
- CompositorElementId expected_compositor_element_id_a =
- CompositorElementId(2, 0);
+ CompositorElementId expected_compositor_element_id_a;
+ expected_compositor_element_id_a.id = 2;
RefPtr<TransformPaintPropertyNode> scroll_translation_a =
TransformPaintPropertyNode::CreateScrollTranslation(
TransformPaintPropertyNode::Root(),
@@ -835,8 +835,8 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees, NestedScrollNodes) {
MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects,
nullptr);
- CompositorElementId expected_compositor_element_id_b =
- CompositorElementId(3, 0);
+ CompositorElementId expected_compositor_element_id_b;
+ expected_compositor_element_id_b.id = 3;
RefPtr<TransformPaintPropertyNode> scroll_translation_b =
TransformPaintPropertyNode::CreateScrollTranslation(
scroll_translation_a, TransformationMatrix().Translate(37, 41),
@@ -1644,7 +1644,8 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees,
}
PassRefPtr<EffectPaintPropertyNode> CreateSampleEffectNodeWithElementId() {
- CompositorElementId expected_compositor_element_id(2, 0);
+ CompositorElementId expected_compositor_element_id;
+ expected_compositor_element_id.id = 2;
float opacity = 2.0 / 255.0;
return EffectPaintPropertyNode::Create(
EffectPaintPropertyNode::Root(), TransformPaintPropertyNode::Root(),
@@ -1655,7 +1656,8 @@ PassRefPtr<EffectPaintPropertyNode> CreateSampleEffectNodeWithElementId() {
PassRefPtr<TransformPaintPropertyNode>
CreateSampleTransformNodeWithElementId() {
- CompositorElementId expected_compositor_element_id(3, 0);
+ CompositorElementId expected_compositor_element_id;
+ expected_compositor_element_id.id = 3;
return TransformPaintPropertyNode::Create(
TransformPaintPropertyNode::Root(), TransformationMatrix().Rotate(90),
FloatPoint3D(100, 100, 0), false, 0, kCompositingReason3DTransform,
@@ -2094,9 +2096,9 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees,
EXPECT_EQ(2u, composited_element_ids.size());
EXPECT_TRUE(
- composited_element_ids.Contains(transform->GetCompositorElementId()));
+ composited_element_ids.Contains(transform->GetCompositorElementId().id));
EXPECT_TRUE(
- composited_element_ids.Contains(effect->GetCompositorElementId()));
+ composited_element_ids.Contains(effect->GetCompositorElementId().id));
}
TEST_F(PaintArtifactCompositorTestWithPropertyTrees, SkipChunkWithOpacityZero) {

Powered by Google App Engine
This is Rietveld 408576698