Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: cc/layers/layer_impl_unittest.cc

Issue 2860293002: Change cc::ElementId to be a uint64_t (Closed)
Patch Set: none Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/layer_impl_unittest.cc
diff --git a/cc/layers/layer_impl_unittest.cc b/cc/layers/layer_impl_unittest.cc
index f8f55537c48a92033f2e319478e6e70ae3c28a08..74ba6f5e496bdf7b08993ffd34ec49576fb38be6 100644
--- a/cc/layers/layer_impl_unittest.cc
+++ b/cc/layers/layer_impl_unittest.cc
@@ -224,8 +224,10 @@ TEST(LayerImplTest, VerifyLayerChangesAreTrackedProperly) {
// Changing these properties does not cause the layer to be marked as changed
// but does cause the layer to need to push properties.
+ ElementId element_id;
+ element_id.id = 3;
EXECUTE_AND_VERIFY_NEEDS_PUSH_PROPERTIES_AND_SUBTREE_DID_NOT_CHANGE(
- root->SetElementId(ElementId(2, 0)));
+ root->SetElementId(element_id));
EXECUTE_AND_VERIFY_NEEDS_PUSH_PROPERTIES_AND_SUBTREE_DID_NOT_CHANGE(
root->SetMutableProperties(MutableProperty::kOpacity);
root->SetNeedsPushProperties());
@@ -349,7 +351,9 @@ TEST(LayerImplTest, VerifyNeedsUpdateDrawProperties) {
VERIFY_NO_NEEDS_UPDATE_DRAW_PROPERTIES(
layer->SetBackgroundColor(arbitrary_color));
VERIFY_NO_NEEDS_UPDATE_DRAW_PROPERTIES(layer->SetBounds(arbitrary_size));
- VERIFY_NO_NEEDS_UPDATE_DRAW_PROPERTIES(layer->SetElementId(ElementId(2, 0)));
+ ElementId element_id;
+ element_id.id = 2;
+ VERIFY_NO_NEEDS_UPDATE_DRAW_PROPERTIES(layer->SetElementId(element_id));
VERIFY_NO_NEEDS_UPDATE_DRAW_PROPERTIES(
layer->SetMutableProperties(MutableProperty::kTransform));
}

Powered by Google App Engine
This is Rietveld 408576698