third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp - Issue 2860293002: Change cc::ElementId to be a uint64_t

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp

Issue 2860293002: Change cc::ElementId to be a uint64_t (Closed)

Patch Set: none Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp ('K') | « third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.cpp ('k') | third_party/WebKit/Source/web/tests/VisualViewportTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp

index 19860120f8e55b2af47294b87adf2defd184e167..880991d5ccf46522b834bbdb9eed78a1d9108fa7 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp

@@ -21,7 +21,7 @@

namespace blink {

ScrollAnimatorCompositorCoordinator::ScrollAnimatorCompositorCoordinator()

- : compositor_animation_attached_to_element_id_(),

+ : compositor_animation_attached_to_element_id_(kInvalidElementId),

run_state_(RunState::kIdle),

compositor_animation_id_(0),

compositor_animation_group_id_(0),

@@ -180,7 +180,8 @@ void ScrollAnimatorCompositorCoordinator::CompositorAnimationFinished(

bool ScrollAnimatorCompositorCoordinator::ReattachCompositorPlayerIfNeeded(

CompositorAnimationTimeline* timeline) {

bool reattached = false;

- CompositorElementId compositor_animation_attached_to_element_id;

+ CompositorElementId compositor_animation_attached_to_element_id =

+ kInvalidElementId;

if (GetScrollableArea()->LayerForScrolling()) {

compositor_animation_attached_to_element_id = GetScrollableArea()

->LayerForScrolling()