third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp - Issue 2860293002: Change cc::ElementId to be a uint64_t

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp

Issue 2860293002: Change cc::ElementId to be a uint64_t (Closed)

Patch Set: none Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/DOMNodeIds.h ('K') | « third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp ('k') | third_party/WebKit/Source/platform/graphics/CompositorElementId.h » ('j') | third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp

diff --git a/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp b/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp

index 50ab0381c8a361505a5b4ac9d0e3daa449f80d59..d0cde47b4b8c045b75c153d17bf64a93b6cb17e0 100644

--- a/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp

+++ b/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp

@@ -50,7 +50,7 @@ TEST_F(HTMLCanvasElementModuleTest, TransferControlToOffscreen) {

NonThrowableExceptionState exception_state;

OffscreenCanvas* offscreen_canvas =

TransferControlToOffscreen(exception_state);

- int canvas_id = offscreen_canvas->PlaceholderCanvasId();

+ unsigned canvas_id = offscreen_canvas->PlaceholderCanvasId();

EXPECT_EQ(canvas_id, DOMNodeIds::IdForNode(&(CanvasElement())));

}