Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h

Issue 2860293002: Change cc::ElementId to be a uint64_t (Closed)
Patch Set: none Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h
diff --git a/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h b/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h
index 3d5b7820d210832b2a1f854bdb9c52183ed40784..eefa999aaec147411c1b78d56b9cd1b592e8d7ab 100644
--- a/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h
+++ b/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h
@@ -59,10 +59,10 @@ class CORE_EXPORT OffscreenCanvas final
const IntSize& Size() const override { return size_; }
void SetSize(const IntSize&);
- void SetPlaceholderCanvasId(int canvas_id) {
+ void SetPlaceholderCanvasId(unsigned canvas_id) {
ajuma 2017/05/05 13:46:42 uint64_t? (here and below)
chrishtr 2017/05/05 15:37:47 Done.
placeholder_canvas_id_ = canvas_id;
}
- int PlaceholderCanvasId() const { return placeholder_canvas_id_; }
+ unsigned PlaceholderCanvasId() const { return placeholder_canvas_id_; }
bool HasPlaceholderCanvas() {
return placeholder_canvas_id_ != kNoPlaceholderCanvas;
}
@@ -167,10 +167,10 @@ class CORE_EXPORT OffscreenCanvas final
WeakMember<ExecutionContext> execution_context_;
enum {
- kNoPlaceholderCanvas = -1, // DOMNodeIds starts from 0, using -1 to
- // indicate no associated canvas element.
+ kNoPlaceholderCanvas = 0, // DOMNodeIds starts from 1, using 0 to
+ // indicate no associated canvas element.
};
- int placeholder_canvas_id_ = kNoPlaceholderCanvas;
+ unsigned placeholder_canvas_id_ = kNoPlaceholderCanvas;
IntSize size_;
bool is_neutered_ = false;

Powered by Google App Engine
This is Rietveld 408576698