Change cc::ElementId to be a uint64_t

cc/trees/element_id.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_TREES_ELEMENT_ID_H_
 #define CC_TREES_ELEMENT_ID_H_
 
-#include <stddef.h>
-
-#include <cstdint>
-#include <functional>
-#include <iosfwd>
-#include <memory>
-
-#include "base/hash.h"
-#include "cc/cc_export.h"
-
-namespace base {
-class Value;
-namespace trace_event {
-class TracedValue;
-}  // namespace trace_event
-}  // namespace base
+#include <stdint.h>
 
 namespace cc {
 
-// Element ids are chosen by cc's clients and can be used as a stable identifier

[wkorman, 2017/05/05 20:06:10]

Shouldn't we keep some of this documentation? Or, where has it moved to?

[chrishtr, 2017/05/05 20:46:09]

Oh right. Re-added.

-// across updates.
-//
-// Historically, the layer tree stored all compositing data but this has been
-// refactored over time into auxilliary structures such as property trees.
-//
-// In composited scrolling, Layers directly reference scroll tree nodes
-// (Layer::scroll_tree_index) but scroll tree nodes are being refactored to
-// reference stable element ids instead of layers. Scroll property nodes have
-// unique element ids that blink creates from scrollable areas (though this is
-// opaque to the compositor). This refactoring of scroll nodes keeping a
-// scrolling element id instead of a scrolling layer id allows for more general
-// compositing where, for example, multiple layers scroll with one scroll node.
-//
-// The animation system (see: ElementAnimations and blink::ElementAnimations) is
-// another auxilliary structure to the layer tree and uses element ids as a
-// stable identifier for animation targets. A Layer's element id can change over
-// the Layer's lifetime because non-default ElementIds are only set during an
-// animation's lifetime.
-struct CC_EXPORT ElementId {
-  ElementId(int primaryId, int secondaryId)
-      : primaryId(primaryId), secondaryId(secondaryId) {}
-  ElementId() : ElementId(0, 0) {}
+using ElementId = uint64_t;
 
-  bool operator==(const ElementId& o) const;
-  bool operator!=(const ElementId& o) const;
-  bool operator<(const ElementId& o) const;
-
-  // An ElementId's conversion to a boolean value depends only on its primaryId.
-  explicit operator bool() const;
-
-  void AddToTracedValue(base::trace_event::TracedValue* res) const;
-  std::unique_ptr<base::Value> AsValue() const;
-
-  // The compositor treats this as an opaque handle and should not know how to
-  // interpret these bits. Non-blink cc clients typically operate in terms of
-  // layers and may set this value to match the client's layer id.
-  int primaryId;
-  int secondaryId;
-};
-
-CC_EXPORT ElementId LayerIdToElementIdForTesting(int layer_id);
-
-struct CC_EXPORT ElementIdHash {
-  size_t operator()(ElementId key) const;
-};
-
-// Stream operator so ElementId can be used in assertion statements.
-CC_EXPORT std::ostream& operator<<(std::ostream& out, const ElementId& id);

[wkorman, 2017/05/05 20:06:10]

It occurs to me, just to mention another non obvious effect of this change, that
viewing element id in log output is made more complex.

With separate primary/secondary fields and the stream operator the values could
be easily discerned.

This is not a big deal since perhaps we'll do away with the secondary value but
wanted to mention. We could add a ToString-type method if we needed it in
interim.

+static const ElementId kInvalidElementId = 0;
 
 }  // namespace cc
 
 #endif  // CC_TREES_ELEMENT_ID_H_