third_party/WebKit/Source/core/dom/DOMNodeIds.h - Issue 2860293002: Change cc::ElementId to be a uint64_t

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/dom/DOMNodeIds.h

Issue 2860293002: Change cc::ElementId to be a uint64_t (Closed)

Patch Set: none Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« cc/trees/tree_synchronizer_unittest.cc ('K') | « third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp ('k') | third_party/WebKit/Source/core/dom/DOMNodeIds.cpp » ('j') | third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef DOMNodeIds_h	5 #ifndef DOMNodeIds_h

6 #define DOMNodeIds_h	6 #define DOMNodeIds_h

7	7

8 #include "core/CoreExport.h"	8 #include "core/CoreExport.h"

9 #include "core/dom/Node.h"	9 #include "core/dom/Node.h"

10 #include "core/dom/WeakIdentifierMap.h"	10 #include "core/dom/WeakIdentifierMap.h"

11 #include "platform/wtf/Allocator.h"	11 #include "platform/wtf/Allocator.h"

12	12

13 namespace blink {	13 namespace blink {

14	14

15 DECLARE_WEAK_IDENTIFIER_MAP(Node);	15 DECLARE_WEAK_IDENTIFIER_MAP(Node, unsigned long long);

16	16

17 class CORE_EXPORT DOMNodeIds {	17 class CORE_EXPORT DOMNodeIds {

18 STATIC_ONLY(DOMNodeIds);	18 STATIC_ONLY(DOMNodeIds);

19	19

20 public:	20 public:

21 static int IdForNode(Node*);	21 static unsigned long long IdForNode(Node*);
	suzyh_UTC10 (ex-contributor) 2017/05/05 04:27:30 Is this "unsigned long long" different from the El Is this "unsigned long long" different from the ElementId "unsigned long long"? If not, why not use ElementId here? chrishtr 2017/05/05 05:34:52 It's different from ElementId, because: * ElementI Show quoted text On 2017/05/05 at 04:27:30, suzyh_UTC10 wrote: > Is this "unsigned long long" different from the ElementId "unsigned long long"? If not, why not use ElementId here? It's different from ElementId, because: * ElementId is a conceptual encoding of primary and secondary keys. * DOMNodeIds has more than one consumer (OffscreenCanvas is another).
22 static Node* NodeForId(int id);	22 static Node* NodeForId(unsigned long long id);

23 };	23 };

24	24

25 } // namespace blink	25 } // namespace blink

26	26

27 #endif // DOMNodeIds_h	27 #endif // DOMNodeIds_h

OLD	NEW