Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2860263002: NOT FOR COMMIT: Move background pausing to the WebView level

Created:
3 years, 7 months ago by ojan
Modified:
3 years, 7 months ago
Reviewers:
Z_DONOTUSE, Sami
CC:
altimin, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, scheduler-bugs_chromium.org, Sami
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

NOT FOR COMMIT: Move background pausing to the WebView level This way the pausing happens per tab instead of per process. This also means we pause the suspendable task queue as well. BUG=709082, 670102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -299 lines) Patch
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h View 6 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc View 10 chunks +2 lines, -90 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc View 2 chunks +140 lines, -138 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc View 6 chunks +44 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/test/fake_renderer_scheduler.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/public/platform/scheduler/renderer/renderer_scheduler.h View 2 chunks +0 lines, -15 lines 0 comments Download
M third_party/WebKit/public/platform/scheduler/test/fake_renderer_scheduler.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/scheduler/test/mock_renderer_scheduler.h View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Z_DONOTUSE
altimin/skyostil: FYI, I have a patch in progress for this. It needs tests and a ...
3 years, 7 months ago (2017-05-05 00:20:53 UTC) #3
Sami
This seems workable, although I wonder if still need to suspend the top level timer/loading ...
3 years, 7 months ago (2017-05-05 14:36:36 UTC) #5
Z_DONOTUSE
On 2017/05/05 at 14:36:36, skyostil wrote: > This seems workable, although I wonder if still ...
3 years, 7 months ago (2017-05-05 17:27:03 UTC) #6
Z_DONOTUSE
Ugh. Elliott also pointed out that this isn't safe as is. A foreground popup window ...
3 years, 7 months ago (2017-05-05 20:53:28 UTC) #7
Z_DONOTUSE
3 years, 7 months ago (2017-05-05 23:38:57 UTC) #8
Looks like there's an idea to plumb this data down into platform in
crbug.com/718489. I think this patch is probably blocked on that.

Powered by Google App Engine
This is Rietveld 408576698