Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java

Issue 2860193002: Correctly record WebAPK install source for Launch.HomescreenSource (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java
index 949ece8ca28bf62dd7d23eed66bed2d6ddd097af..e0beb6a4f711d43178f8d5ad73b32d09cadd54a3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java
@@ -75,9 +75,8 @@ public class WebappInfo {
return IntentUtils.safeGetStringExtra(intent, ShortcutHelper.EXTRA_URL);
}
- protected static int sourceFromIntent(Intent intent) {
- return IntentUtils.safeGetIntExtra(
- intent, ShortcutHelper.EXTRA_SOURCE, ShortcutSource.UNKNOWN);
+ protected static int sourceFromIntent(Intent intent, int defaultSource) {
+ return IntentUtils.safeGetIntExtra(intent, ShortcutHelper.EXTRA_SOURCE, defaultSource);
}
private static String titleFromIntent(Intent intent) {
@@ -111,7 +110,7 @@ public class WebappInfo {
intent, ShortcutHelper.EXTRA_DISPLAY_MODE, WebDisplayMode.STANDALONE);
int orientation = IntentUtils.safeGetIntExtra(
intent, ShortcutHelper.EXTRA_ORIENTATION, ScreenOrientationValues.DEFAULT);
- int source = sourceFromIntent(intent);
+ int source = sourceFromIntent(intent, ShortcutSource.UNKNOWN);
long themeColor = IntentUtils.safeGetLongExtra(intent,
ShortcutHelper.EXTRA_THEME_COLOR,
ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING);

Powered by Google App Engine
This is Rietveld 408576698