Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: chrome/browser/android/shortcut_info.h

Issue 2860193002: Correctly record WebAPK install source for Launch.HomescreenSource (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_ 5 #ifndef CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_
6 #define CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_ 6 #define CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 // Used for bookmark-type shortcuts that launch the tabbed browser. 43 // Used for bookmark-type shortcuts that launch the tabbed browser.
44 SOURCE_ADD_TO_HOMESCREEN_SHORTCUT = 8, 44 SOURCE_ADD_TO_HOMESCREEN_SHORTCUT = 8,
45 45
46 // Used for WebAPKs launched via an external intent. 46 // Used for WebAPKs launched via an external intent.
47 SOURCE_EXTERNAL_INTENT = 9, 47 SOURCE_EXTERNAL_INTENT = 9,
48 48
49 // Used for WebAPK PWAs added via the banner. 49 // Used for WebAPK PWAs added via the banner.
50 SOURCE_APP_BANNER_WEBAPK = 10, 50 SOURCE_APP_BANNER_WEBAPK = 10,
51 51
52 SOURCE_COUNT = 11 52 // Used for WebAPK PWAs whose install source info are lost.
pkotwicz 2017/05/05 21:05:43 Nit: "are lost" -> "was lost" (because "source inf
Xi Han 2017/05/08 20:55:28 Thanks!
53 SOURCE_WEBAPK_UNKNOWN = 11,
54
55 SOURCE_COUNT = 12
53 }; 56 };
54 57
55 explicit ShortcutInfo(const GURL& shortcut_url); 58 explicit ShortcutInfo(const GURL& shortcut_url);
56 ShortcutInfo(const ShortcutInfo& other); 59 ShortcutInfo(const ShortcutInfo& other);
57 ~ShortcutInfo(); 60 ~ShortcutInfo();
58 61
59 // Updates the info based on the given |manifest|. 62 // Updates the info based on the given |manifest|.
60 void UpdateFromManifest(const content::Manifest& manifest); 63 void UpdateFromManifest(const content::Manifest& manifest);
61 64
62 // Updates the source of the shortcut. 65 // Updates the source of the shortcut.
(...skipping 12 matching lines...) Expand all
75 int64_t background_color; 78 int64_t background_color;
76 int ideal_splash_image_size_in_px; 79 int ideal_splash_image_size_in_px;
77 int minimum_splash_image_size_in_px; 80 int minimum_splash_image_size_in_px;
78 GURL splash_image_url; 81 GURL splash_image_url;
79 GURL best_primary_icon_url; 82 GURL best_primary_icon_url;
80 GURL best_badge_icon_url; 83 GURL best_badge_icon_url;
81 std::vector<std::string> icon_urls; 84 std::vector<std::string> icon_urls;
82 }; 85 };
83 86
84 #endif // CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_ 87 #endif // CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698