Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2860173002: Create KernelVariableDeclaration for formal parameters. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create KernelVariableDeclaration for formal parameters. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/888097781b05e7e42cdcbc0343297fbf02dcc681

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -20 lines) Patch
M pkg/analyzer_plugin/analyzer_plugin.iml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart View 3 chunks +8 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +3 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 7 months ago (2017-05-04 19:33:13 UTC) #1
Paul Berry
lgtm
3 years, 7 months ago (2017-05-04 19:57:55 UTC) #2
scheglov
3 years, 7 months ago (2017-05-04 20:32:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
888097781b05e7e42cdcbc0343297fbf02dcc681 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698