Added alternative configuration for the data reduction proxy

chrome/browser/net/spdyproxy/proxy_advisor.cc

Index: chrome/browser/net/spdyproxy/proxy_advisor.cc
diff --git a/chrome/browser/net/spdyproxy/proxy_advisor.cc b/chrome/browser/net/spdyproxy/proxy_advisor.cc
index f15851acc400a4d6b202f3dc5e1a737e9d71a652..77a346aafcc7fbb4a6ee1a59a80fae709e31bbf1 100644
--- a/chrome/browser/net/spdyproxy/proxy_advisor.cc
+++ b/chrome/browser/net/spdyproxy/proxy_advisor.cc
@@ -11,6 +11,7 @@
 #include "base/stl_util.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
+#include "components/data_reduction_proxy/browser/data_reduction_proxy_params.h"
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_settings.h"
 #include "content/public/browser/browser_thread.h"
 #include "net/base/load_flags.h"
@@ -21,6 +22,8 @@
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 
+// TODO(marq): Remove this class because it is not being used.

[mmenke, 2014/05/21 16:00:20]

Which class?

[bengr, 2014/05/28 01:25:32]

This ProxyAdvisor class.

+
 // Ensure data reduction features are available.
 #if !defined(OS_ANDROID) && !defined(OS_IOS)
 #error proxy_advisor should only be included in Android or iOS builds.
@@ -119,8 +122,10 @@ void ProxyAdvisor::Advise(
   std::string motivation_name(MotivationName(motivation, is_preconnect));
   std::string header_value = motivation_name + " " + url.spec();
   net::URLRequestContext* context = context_getter_->GetURLRequestContext();
+  data_reduction_proxy::DataReductionProxyParams params(
+      true, true, false, true);

[mmenke, 2014/05/21 16:00:20]

Suggest either enums instead of bools, or adding comments with the variable
names here after each of the bools.  A bunch of bools can be hard to follow.

[sgurun-gerrit only, 2014/05/21 16:21:29]

I like the idea of using enums. It will be a lot more readable.

On 2014/05/21 16:00:20, mmenke wrote:

[bengr, 2014/05/28 01:25:32]

Done.

   std::string endpoint =
-      DataReductionProxySettings::GetDataReductionProxyOrigin() + "preconnect";
+      params.origin().spec() + "preconnect";
   scoped_ptr<net::URLRequest> request = context->CreateRequest(
       GURL(endpoint), net::DEFAULT_PRIORITY, this, NULL);
   request->set_method("HEAD");