Chromium Code Reviews

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java

Issue 286013002: Added alternative configuration for the data reduction proxy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java b/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java
index c11c7c8d02a84f55552f8ea6eb633c03d390599b..4444a6f3310f06b179896bed10151403627204ae 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java
@@ -10,8 +10,15 @@ import org.chromium.base.ThreadUtils;
import java.text.NumberFormat;
import java.util.Locale;
+/**
+ * Entry point to manage all data reduction proxy configuration details.
+ */
public class DataReductionProxySettings {
+ /**
+ * Data structure to hold the original content length before data reduction and the received
+ * content length after data reduction.
+ */
public static class ContentLengths {
private final long mOriginal;
private final long mReceived;
@@ -37,6 +44,9 @@ public class DataReductionProxySettings {
private static DataReductionProxySettings sSettings;
+ /**
+ * Returns a singleton instance of the settings object.
+ */
public static DataReductionProxySettings getInstance() {
ThreadUtils.assertOnUiThread();
if (sSettings == null) {
@@ -52,14 +62,6 @@ public class DataReductionProxySettings {
// DataReductionProxySettings is a singleton that lives forever and there's no clean
// shutdown of Chrome on Android
mNativeDataReductionProxySettings = nativeInit();
- initDataReductionProxySettings();
- }
-
- /**
- * Initializes the data reduction proxy at Chrome startup.
- */
- public void initDataReductionProxySettings() {
- nativeInitDataReductionProxySettings(mNativeDataReductionProxySettings);
}
/**
@@ -191,8 +193,6 @@ public class DataReductionProxySettings {
}
private native long nativeInit();
- private native void nativeInitDataReductionProxySettings(
- long nativeDataReductionProxySettingsAndroid);
private native void nativeBypassHostPattern(
long nativeDataReductionProxySettingsAndroid, String pattern);
private native void nativeBypassURLPattern(

Powered by Google App Engine