Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Issue 2860093003: Implement device-ram client hints header (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
index c71f73dd74430bd4a9f6b700dadfd961078d83fb..4e2b8f2599d54d0235d3df2e5218cef785ed6f4a 100644
--- a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
@@ -606,6 +606,22 @@ void FrameFetchContext::ModifyRequestForCSP(ResourceRequest& resource_request) {
GetFrame()->Loader().ModifyRequestForCSP(resource_request, GetDocument());
}
+float FrameFetchContext::ClientHintsDeviceRAM(int physical_memory_mb) {
+ // TODO(fmeawad): The calculations in this method are still evolving as the
+ // spec gets updated: https://github.com/WICG/device-ram The reported
+ // device-ram is rounded down to next power of 2 in GB. Ex. 3072MB will return
+ // 2, and 768MB will return 0.5.
+ DCHECK_GT(physical_memory_mb, 0);
+ int power = -1; // To compensate of the extra loop iteration.
+ // Extract the MSB location.
+ while (physical_memory_mb != 0) {
+ physical_memory_mb >>= 1;
+ power++;
+ }
+ // Restore to the power of 2, and convert to GB.
+ return (float)(1 << power) / (float)1024.0;
+}
+
void FrameFetchContext::AddClientHintsIfNecessary(
const ClientHintsPreferences& hints_preferences,
const FetchParameters::ResourceWidth& resource_width,
@@ -613,6 +629,9 @@ void FrameFetchContext::AddClientHintsIfNecessary(
if (!RuntimeEnabledFeatures::clientHintsEnabled() || !GetDocument())
return;
+ bool should_send_device_ram =
+ GetDocument()->GetClientHintsPreferences().ShouldSendDeviceRAM() ||
+ hints_preferences.ShouldSendDeviceRAM();
bool should_send_dpr =
GetDocument()->GetClientHintsPreferences().ShouldSendDPR() ||
hints_preferences.ShouldSendDPR();
@@ -623,6 +642,13 @@ void FrameFetchContext::AddClientHintsIfNecessary(
GetDocument()->GetClientHintsPreferences().ShouldSendViewportWidth() ||
hints_preferences.ShouldSendViewportWidth();
+ if (should_send_device_ram) {
+ int physical_memory = Platform::Current()->AmountOfPhysicalMemoryMB();
+ request.AddHTTPHeaderField(
+ "device-ram",
+ AtomicString(String::Number(ClientHintsDeviceRAM(physical_memory))));
+ }
+
if (should_send_dpr) {
request.AddHTTPHeaderField(
"DPR", AtomicString(String::Number(GetDocument()->DevicePixelRatio())));

Powered by Google App Engine
This is Rietveld 408576698