Implement device-ram client hints header

third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

 /*
  * Copyright (c) 2015, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 476 matching lines @@
   resource_request.SetRequestContext(WebURLRequest::kRequestContextScript);
   fetch_context->PopulateResourceRequest(
       url, Resource::kScript, ClientHintsPreferences(),
       FetchParameters::ResourceWidth(), ResourceLoaderOptions(),
       SecurityViolationReportingPolicy::kReport, resource_request);
   EXPECT_EQ(1u, policy->violation_reports_sent_.size());
   // Check that the resource was upgraded to a secure URL.
   EXPECT_EQ(KURL(KURL(), "https://baz.test"), resource_request.Url());
 }
 
 class FrameFetchContextHintsTest : public FrameFetchContextTest {

[kinuko, 2017/05/25 05:05:51]

For these ones I suspect we could just use TestingPlatformSupport so that we
don't need to add SetDevicePhysicalMemoryMBForTesting on Platform (but only add
it on the test platform class)?

[fmeawad, 2017/05/25 19:53:34]

Done.

  public:
   FrameFetchContextHintsTest() {}
 
  protected:
   void ExpectHeader(const char* input,
                     const char* header_name,
                     bool is_present,
                     const char* header_value,
                     float width = 0) {
     ClientHintsPreferences hints_preferences;
 
     FetchParameters::ResourceWidth resource_width;
     if (width > 0) {
       resource_width.width = width;
       resource_width.is_set = true;
     }
 
     KURL input_url(kParsedURLString, input);
     ResourceRequest resource_request(input_url);
 
     fetch_context->AddClientHintsIfNecessary(hints_preferences, resource_width,
                                              resource_request);
 
     EXPECT_EQ(is_present ? String(header_value) : String(),
               resource_request.HttpHeaderField(header_name));
   }
 };
 
+TEST_F(FrameFetchContextHintsTest, MonitorDeviceRAMHints) {
+  ExpectHeader("http://www.example.com/1.gif", "device-ram", false, "");
+  ClientHintsPreferences preferences;
+  preferences.SetShouldSendDeviceRAM(true);
+  document->GetClientHintsPreferences().UpdateFrom(preferences);
+  Platform::Current()->SetDevicePhysicalMemoryMBForTesting(4096);
+  ExpectHeader("http://www.example.com/1.gif", "device-ram", true, "4");
+  Platform::Current()->SetDevicePhysicalMemoryMBForTesting(2048);
+  ExpectHeader("http://www.example.com/1.gif", "device-ram", true, "2");
+  Platform::Current()->SetDevicePhysicalMemoryMBForTesting(64385);
+  ExpectHeader("http://www.example.com/1.gif", "device-ram", true, "32");
+  Platform::Current()->SetDevicePhysicalMemoryMBForTesting(768);
+  ExpectHeader("http://www.example.com/1.gif", "device-ram", true, "0.5");
+  ExpectHeader("http://www.example.com/1.gif", "DPR", false, "");
+  ExpectHeader("http://www.example.com/1.gif", "Width", false, "");
+  ExpectHeader("http://www.example.com/1.gif", "Viewport-Width", false, "");
+}
+
 TEST_F(FrameFetchContextHintsTest, MonitorDPRHints) {
   ExpectHeader("http://www.example.com/1.gif", "DPR", false, "");
   ClientHintsPreferences preferences;
   preferences.SetShouldSendDPR(true);
   document->GetClientHintsPreferences().UpdateFrom(preferences);
   ExpectHeader("http://www.example.com/1.gif", "DPR", true, "1");
   dummy_page_holder->GetPage().SetDeviceScaleFactorDeprecated(2.5);
   ExpectHeader("http://www.example.com/1.gif", "DPR", true, "2.5");
   ExpectHeader("http://www.example.com/1.gif", "Width", false, "");
   ExpectHeader("http://www.example.com/1.gif", "Viewport-Width", false, "");
@@ skipping 20 matching lines @@
   ExpectHeader("http://www.example.com/1.gif", "Viewport-Width", true, "500");
   dummy_page_holder->GetFrameView().SetLayoutSizeFixedToFrameSize(false);
   dummy_page_holder->GetFrameView().SetLayoutSize(IntSize(800, 800));
   ExpectHeader("http://www.example.com/1.gif", "Viewport-Width", true, "800");
   ExpectHeader("http://www.example.com/1.gif", "Viewport-Width", true, "800",
                666.6666);
   ExpectHeader("http://www.example.com/1.gif", "DPR", false, "");
 }
 
 TEST_F(FrameFetchContextHintsTest, MonitorAllHints) {
+  ExpectHeader("http://www.example.com/1.gif", "device-ram", false, "");
   ExpectHeader("http://www.example.com/1.gif", "DPR", false, "");
   ExpectHeader("http://www.example.com/1.gif", "Viewport-Width", false, "");
   ExpectHeader("http://www.example.com/1.gif", "Width", false, "");
 
   ClientHintsPreferences preferences;
+  preferences.SetShouldSendDeviceRAM(true);
   preferences.SetShouldSendDPR(true);
   preferences.SetShouldSendResourceWidth(true);
   preferences.SetShouldSendViewportWidth(true);
+  Platform::Current()->SetDevicePhysicalMemoryMBForTesting(4096);
   document->GetClientHintsPreferences().UpdateFrom(preferences);
+  ExpectHeader("http://www.example.com/1.gif", "device-ram", true, "4");
   ExpectHeader("http://www.example.com/1.gif", "DPR", true, "1");
   ExpectHeader("http://www.example.com/1.gif", "Width", true, "400", 400);
   ExpectHeader("http://www.example.com/1.gif", "Viewport-Width", true, "500");
 }
 
+TEST_F(FrameFetchContextHintsTest, ClientHintsDeviceRAM) {
+  EXPECT_EQ(0.125, FrameFetchContext::ClientHintsDeviceRAM(128));  // 128MB
+  EXPECT_EQ(0.25, FrameFetchContext::ClientHintsDeviceRAM(256));   // 256MB
+  EXPECT_EQ(0.25, FrameFetchContext::ClientHintsDeviceRAM(510));   // <512MB
+  EXPECT_EQ(0.5, FrameFetchContext::ClientHintsDeviceRAM(512));    // 512MB
+  EXPECT_EQ(0.5, FrameFetchContext::ClientHintsDeviceRAM(640));    // 512+128MB
+  EXPECT_EQ(0.5, FrameFetchContext::ClientHintsDeviceRAM(768));    // 512+256MB
+  EXPECT_EQ(0.5, FrameFetchContext::ClientHintsDeviceRAM(1000));   // <1GB
+  EXPECT_EQ(1, FrameFetchContext::ClientHintsDeviceRAM(1024));     // 1GB
+  EXPECT_EQ(1, FrameFetchContext::ClientHintsDeviceRAM(1536));     // 1.5GB
+  EXPECT_EQ(1, FrameFetchContext::ClientHintsDeviceRAM(2000));     // <2GB
+  EXPECT_EQ(2, FrameFetchContext::ClientHintsDeviceRAM(2048));     // 2GB
+  EXPECT_EQ(4, FrameFetchContext::ClientHintsDeviceRAM(5120));     // 5GB
+  EXPECT_EQ(8, FrameFetchContext::ClientHintsDeviceRAM(8192));     // 8GB
+  EXPECT_EQ(16, FrameFetchContext::ClientHintsDeviceRAM(16384));   // 16GB
+  EXPECT_EQ(32, FrameFetchContext::ClientHintsDeviceRAM(32768));   // 32GB
+  EXPECT_EQ(32, FrameFetchContext::ClientHintsDeviceRAM(64385));   // <64GB
+}
+
 TEST_F(FrameFetchContextTest, MainResourceCachePolicy) {
   // Default case
   ResourceRequest request("http://www.example.com");
   EXPECT_EQ(WebCachePolicy::kUseProtocolCachePolicy,
             fetch_context->ResourceRequestCachePolicy(
                 request, Resource::kMainResource, FetchParameters::kNoDefer));
 
   // Post
   ResourceRequest post_request("http://www.example.com");
   post_request.SetHTTPMethod(HTTPNames::POST);
@@ skipping 315 matching lines @@
   SetFilterPolicy(WebDocumentSubresourceFilter::kWouldDisallow);
 
   EXPECT_EQ(ResourceRequestBlockedReason::kNone, CanRequest());
   EXPECT_EQ(0, GetFilteredLoadCallCount());
 
   EXPECT_EQ(ResourceRequestBlockedReason::kNone, CanRequestPreload());
   EXPECT_EQ(0, GetFilteredLoadCallCount());
 }
 
 }  // namespace blink