Implement device-ram client hints header

third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

 /*
  * Copyright (c) 2015, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 503 matching lines @@
     ResourceRequest resource_request(input_url);
 
     fetch_context->AddClientHintsIfNecessary(hints_preferences, resource_width,
                                              resource_request);
 
     EXPECT_EQ(is_present ? String(header_value) : String(),
               resource_request.HttpHeaderField(header_name));
   }
 };
 
+TEST_F(FrameFetchContextHintsTest, MonitorDeviceRamHints) {

[panicker, 2017/05/05 17:19:30]

Also add a unittest with different values of physical ram (include edge cases)
to test the computed value

[fmeawad, 2017/05/23 20:50:54]

Done.

+  ExpectHeader("http://www.example.com/1.gif", "device-ram", false, "");
+  ClientHintsPreferences preferences;
+  preferences.SetShouldSendDeviceRam(true);
+  document->GetClientHintsPreferences().UpdateFrom(preferences);
+  ExpectHeader("http://www.example.com/1.gif", "device-ram", true, "4");
+  dummy_page_holder->GetPage().SetDeviceScaleFactorDeprecated(2.5);
+  ExpectHeader("http://www.example.com/1.gif", "device-ram", true, "2.5");
+  ExpectHeader("http://www.example.com/1.gif", "Width", false, "");
+  ExpectHeader("http://www.example.com/1.gif", "Viewport-Width", false, "");
+}
+
 TEST_F(FrameFetchContextHintsTest, MonitorDPRHints) {
   ExpectHeader("http://www.example.com/1.gif", "DPR", false, "");
   ClientHintsPreferences preferences;
   preferences.SetShouldSendDPR(true);
   document->GetClientHintsPreferences().UpdateFrom(preferences);
   ExpectHeader("http://www.example.com/1.gif", "DPR", true, "1");
   dummy_page_holder->GetPage().SetDeviceScaleFactorDeprecated(2.5);
   ExpectHeader("http://www.example.com/1.gif", "DPR", true, "2.5");
   ExpectHeader("http://www.example.com/1.gif", "Width", false, "");
   ExpectHeader("http://www.example.com/1.gif", "Viewport-Width", false, "");
@@ skipping 20 matching lines @@
   ExpectHeader("http://www.example.com/1.gif", "Viewport-Width", true, "500");
   dummy_page_holder->GetFrameView().SetLayoutSizeFixedToFrameSize(false);
   dummy_page_holder->GetFrameView().SetLayoutSize(IntSize(800, 800));
   ExpectHeader("http://www.example.com/1.gif", "Viewport-Width", true, "800");
   ExpectHeader("http://www.example.com/1.gif", "Viewport-Width", true, "800",
                666.6666);
   ExpectHeader("http://www.example.com/1.gif", "DPR", false, "");
 }
 
 TEST_F(FrameFetchContextHintsTest, MonitorAllHints) {
+  ExpectHeader("http://www.example.com/1.gif", "device-ram", false, "");
   ExpectHeader("http://www.example.com/1.gif", "DPR", false, "");
   ExpectHeader("http://www.example.com/1.gif", "Viewport-Width", false, "");
   ExpectHeader("http://www.example.com/1.gif", "Width", false, "");
 
   ClientHintsPreferences preferences;
+  preferences.SetShouldSendDeviceRam(true);
   preferences.SetShouldSendDPR(true);
   preferences.SetShouldSendResourceWidth(true);
   preferences.SetShouldSendViewportWidth(true);
   document->GetClientHintsPreferences().UpdateFrom(preferences);
+  ExpectHeader("http://www.example.com/1.gif", "device-ram", true, "4");
   ExpectHeader("http://www.example.com/1.gif", "DPR", true, "1");
   ExpectHeader("http://www.example.com/1.gif", "Width", true, "400", 400);
   ExpectHeader("http://www.example.com/1.gif", "Viewport-Width", true, "500");
 }
 
 TEST_F(FrameFetchContextTest, MainResourceCachePolicy) {
   // Default case
   ResourceRequest request("http://www.example.com");
   EXPECT_EQ(WebCachePolicy::kUseProtocolCachePolicy,
             fetch_context->ResourceRequestCachePolicy(
@@ skipping 320 matching lines @@
   SetFilterPolicy(WebDocumentSubresourceFilter::kWouldDisallow);
 
   EXPECT_EQ(ResourceRequestBlockedReason::kNone, CanRequest());
   EXPECT_EQ(0, GetFilteredLoadCallCount());
 
   EXPECT_EQ(ResourceRequestBlockedReason::kNone, CanRequestPreload());
   EXPECT_EQ(0, GetFilteredLoadCallCount());
 }
 
 }  // namespace blink