Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 286003003: Remove instant-search-clicks flag. (Closed)

Created:
6 years, 7 months ago by ksimbili1
Modified:
6 years, 7 months ago
Reviewers:
ksimbili, Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove instant-search-clicks flag. BUG=373381 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
ksimbili
6 years, 7 months ago (2014-05-14 20:28:12 UTC) #1
Yaron
lgtm so you'll revert it again on trunk for dev builds?
6 years, 7 months ago (2014-05-14 20:38:09 UTC) #2
ksimbili
On 2014/05/14 20:38:09, Yaron wrote: > lgtm > > so you'll revert it again on ...
6 years, 7 months ago (2014-05-14 20:39:07 UTC) #3
Yaron
The alternative is to not remove from beta channel. You could also change the code ...
6 years, 7 months ago (2014-05-14 20:40:47 UTC) #4
ksimbili
The CQ bit was checked by ksimbili@google.com
6 years, 7 months ago (2014-05-14 20:42:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksimbili@chromium.org/286003003/1
6 years, 7 months ago (2014-05-14 20:44:22 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 23:34:06 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 23:37:05 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/152066)
6 years, 7 months ago (2014-05-14 23:37:05 UTC) #9
ksimbili
The CQ bit was checked by ksimbili@google.com
6 years, 7 months ago (2014-05-15 01:34:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksimbili@chromium.org/286003003/1
6 years, 7 months ago (2014-05-15 01:35:46 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 01:40:54 UTC) #12
ksimbili
The CQ bit was unchecked by ksimbili@google.com
6 years, 7 months ago (2014-05-15 01:52:33 UTC) #13
ksimbili
The CQ bit was checked by ksimbili@google.com
6 years, 7 months ago (2014-05-15 16:28:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksimbili@chromium.org/286003003/1
6 years, 7 months ago (2014-05-15 16:33:03 UTC) #15
commit-bot: I haz the power
Change committed as 270706
6 years, 7 months ago (2014-05-15 17:11:54 UTC) #16
ksimbili
6 years, 7 months ago (2014-05-15 18:11:15 UTC) #17
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/284233002/ by ksimbili@google.com.

The reason for reverting is: Enabling it for M37 dev builds..

Powered by Google App Engine
This is Rietveld 408576698