|
|
Created:
6 years, 7 months ago by ksimbili1 Modified:
6 years, 7 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionRemove instant-search-clicks flag.
BUG=373381
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270706
Patch Set 1 #
Messages
Total messages: 17 (0 generated)
lgtm so you'll revert it again on trunk for dev builds?
On 2014/05/14 20:38:09, Yaron wrote: > lgtm > > so you'll revert it again on trunk for dev builds? Yeah. Once merged to M35, I'll have to revert this change back. Or is there a better way doing this?
The alternative is to not remove from beta channel. You could also change the code in about:flags to examine the channel but I think that's atypical On Wed, May 14, 2014 at 1:39 PM, <ksimbili@google.com> wrote: > On 2014/05/14 20:38:09, Yaron wrote: > >> lgtm >> > > so you'll revert it again on trunk for dev builds? >> > > Yeah. Once merged to M35, I'll have to revert this change back. Or is > there a > better way doing this? > > https://codereview.chromium.org/286003003/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by ksimbili@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksimbili@chromium.org/286003003/1
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are real, and report flakes to chrome-troopers@google.com. The failing builders are: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...) linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
The CQ bit was checked by ksimbili@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksimbili@chromium.org/286003003/1
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are real, and report flakes to chrome-troopers@google.com. The failing builders are: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
The CQ bit was unchecked by ksimbili@google.com
The CQ bit was checked by ksimbili@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksimbili@chromium.org/286003003/1
Message was sent while issue was closed.
Change committed as 270706
Message was sent while issue was closed.
A revert of this CL has been created in https://codereview.chromium.org/284233002/ by ksimbili@google.com. The reason for reverting is: Enabling it for M37 dev builds.. |