Issue 2860022: Add api to ibus for retreiving unused config values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2860022: Add api to ibus for retreiving unused config values. (Closed)

Created:
10 years, 6 months ago by Zachary Kuznia

Modified:
9 years, 7 months ago

Reviewers:
Yusuke Sato

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org/ibus.git

Visibility:
Public.

Description

Add api to ibus for retreiving unused config values. This will be used by our autotest scripts to generate an error when input method config values change. BUG=chromium-os:3672 TEST=none

Patch Set 1 #

Patch Set 2 : Code Review #

Total comments: 2

Patch Set 3 : Code review changes #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+188 lines, -4 lines)			Patch
M	gconf/config.c	View		3 chunks	+15 lines, -0 lines	0 comments	Download
M	ibus/config.py	View		3 chunks	+12 lines, -0 lines	0 comments	Download
M	memconf/config.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	memconf/config.cc	View	1 2	7 chunks	+54 lines, -2 lines	0 comments	Download
M	src/ibusconfig.h	View		1 chunk	+15 lines, -1 line	0 comments	Download
M	src/ibusconfig.c	View		1 chunk	+45 lines, -0 lines	0 comments	Download
M	src/ibusconfigservice.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	src/ibusconfigservice.c	View		4 chunks	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

10 years, 6 months ago (2010-06-24 05:10:47 UTC) #2

LGTM, thanks for working on this!!

http://codereview.chromium.org/2860022/diff/2001/3003
File memconf/config.cc (right):

http://codereview.chromium.org/2860022/diff/2001/3003#newcode240
memconf/config.cc:240: for (std::set<std::string>::iterator current =
memconf->unread->begin();
nit: const_iterator?

http://codereview.chromium.org/2860022/diff/2001/3003#newcode253
memconf/config.cc:253: for (std::set<std::string>::iterator current =
memconf->unwritten->begin();
ditto

Expand Messages | Collapse Messages