Issue 2860012: Revert 50296 (Causes DCHECK failures) - Make CookieMonster NonThreadSafe....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2860012: Revert 50296 (Causes DCHECK failures) - Make CookieMonster NonThreadSafe.... (Closed)

Created:
10 years, 6 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 50296 (Causes DCHECK failures) - Make CookieMonster NonThreadSafe. Made ExtensionFunction RefCountedThreadSafe so it can be posted to different threads. Used WaitableEvent in AutomationProvider. BUG=44083 Review URL: http://codereview.chromium.org/2756003 TBR=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50357

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -459 lines)			Patch
M	chrome/browser/automation/automation_provider.cc	View	5 chunks	+11 lines, -114 lines	0 comments	Download
M	chrome/browser/extensions/extension_cookies_api.h	View	4 chunks	+14 lines, -65 lines	0 comments	Download
M	chrome/browser/extensions/extension_cookies_api.cc	View	7 chunks	+74 lines, -178 lines	0 comments	Download
M	chrome/browser/extensions/extension_cookies_helpers.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_cookies_helpers.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_data_deleter.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_data_deleter.cc	View	1 chunk	+8 lines, -18 lines	0 comments	Download
M	chrome/browser/extensions/extension_function.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/net/cookie_policy_browsertest.cc	View	6 chunks	+12 lines, -50 lines	0 comments	Download
M	net/base/cookie_monster.h	View	5 chunks	+2 lines, -10 lines	0 comments	Download
M	net/base/cookie_monster.cc	View	12 chunks	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages