Chromium Code Reviews
Help | Chromium Project | Sign in
(160)

Issue 2860012: Revert 50296 (Causes DCHECK failures) - Make CookieMonster NonThreadSafe.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by willchan OOO until 04-22-15
Modified:
3 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, PaweĊ‚ Hajdan Jr., darin-cc_chromium.org
Visibility:
Public.

Description

Revert 50296 (Causes DCHECK failures) - Make CookieMonster NonThreadSafe. Made ExtensionFunction RefCountedThreadSafe so it can be posted to different threads. Used WaitableEvent in AutomationProvider. BUG=44083 Review URL: http://codereview.chromium.org/2756003 TBR=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -459 lines) Patch
M chrome/browser/automation/automation_provider.cc View 5 chunks +11 lines, -114 lines 0 comments Download
M chrome/browser/extensions/extension_cookies_api.h View 4 chunks +14 lines, -65 lines 0 comments Download
M chrome/browser/extensions/extension_cookies_api.cc View 7 chunks +74 lines, -178 lines 0 comments Download
M chrome/browser/extensions/extension_cookies_helpers.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_cookies_helpers.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_data_deleter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_data_deleter.cc View 1 chunk +8 lines, -18 lines 0 comments Download
M chrome/browser/extensions/extension_function.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/net/cookie_policy_browsertest.cc View 6 chunks +12 lines, -50 lines 0 comments Download
M net/base/cookie_monster.h View 5 chunks +2 lines, -10 lines 0 comments Download
M net/base/cookie_monster.cc View 12 chunks +0 lines, -13 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 1 (0 generated)
willchan OOO until 04-22-15
4 years, 9 months ago (2010-06-21 16:04:43 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted