Issue 2860009: [Isolates] Add a preprocessor flag to guard using TLS for the global isolate....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2860009: [Isolates] Add a preprocessor flag to guard using TLS for the global isolate.... (Closed)

Created:
10 years, 6 months ago by zarko

Modified:
9 years, 7 months ago

Reviewers:
Dmitry Titov, Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/isolates/

Visibility:
Public.

Description

[Isolates] Add a preprocessor flag to guard using TLS for the global isolate. - Define V8_USE_TLS_FOR_GLOBAL_ISOLATE to use TLS to look up the global isolate. Committed: http://code.google.com/p/v8/source/detail?r=4887

Patch Set 1 #

Patch Set 2 : integrate latest changes #

Total comments: 4

Patch Set 3 : fixes for comments #

Patch Set 4 : fixes #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -16 lines)			Patch
	M	src/isolate.h	View	1 2	3 chunks	+23 lines, -3 lines	0 comments	Download
	M	src/isolate.cc	View	1 2 3	5 chunks	+34 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dmitry Titov

3 small nits. http://codereview.chromium.org/2860009/diff/4001/5001 File src/isolate.cc (right): http://codereview.chromium.org/2860009/diff/4001/5001#newcode55 src/isolate.cc:55: 2 empty lines before #endif could ...

10 years, 6 months ago (2010-06-17 00:49:09 UTC) #2

zarko

I think I hit the issues. http://codereview.chromium.org/2860009/diff/4001/5001 File src/isolate.cc (right): http://codereview.chromium.org/2860009/diff/4001/5001#newcode102 src/isolate.cc:102: Thread::SetThreadLocal(global_isolate_key_, NULL); On ...

10 years, 6 months ago (2010-06-17 01:13:27 UTC) #3

LGTM

Expand Messages | Collapse Messages