Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: runtime/vm/clustered_snapshot.cc

Issue 2859913002: Resolve inconsistent treatment of stubs in kAppJIT snapshots in favor of write stubs in the snapsho… (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/clustered_snapshot.cc
diff --git a/runtime/vm/clustered_snapshot.cc b/runtime/vm/clustered_snapshot.cc
index 11d9dd050935b76e8347b12e12a45f2de8e12989..8685c23a15bce7cb6378ff4558dac6e0fb827ffe 100644
--- a/runtime/vm/clustered_snapshot.cc
+++ b/runtime/vm/clustered_snapshot.cc
@@ -1934,7 +1934,7 @@ class RODataSerializationCluster : public SerializationCluster {
s->Write<int32_t>(count);
for (intptr_t i = 0; i < count; i++) {
RawObject* object = objects_[i];
- int32_t rodata_offset = s->GetRODataOffset(object);
+ int32_t rodata_offset = s->GetDataOffset(object);
s->Write<int32_t>(rodata_offset);
s->AssignRef(object);
}
@@ -4856,7 +4856,7 @@ void Serializer::AddVMIsolateBaseObjects() {
AddBaseObject(table->At(kDynamicCid));
AddBaseObject(table->At(kVoidCid));
- if (kind_ != Snapshot::kAppAOT) {
+ if (!Snapshot::IncludesCode(kind_)) {
for (intptr_t i = 0; i < StubCode::NumEntries(); i++) {
AddBaseObject(StubCode::EntryAt(i)->code());
}
@@ -5261,7 +5261,7 @@ void Deserializer::AddVMIsolateBaseObjects() {
AddBaseObject(table->At(kDynamicCid));
AddBaseObject(table->At(kVoidCid));
- if (kind_ != Snapshot::kAppAOT) {
+ if (!Snapshot::IncludesCode(kind_)) {
for (intptr_t i = 0; i < StubCode::NumEntries(); i++) {
AddBaseObject(StubCode::EntryAt(i)->code());
}
« no previous file with comments | « runtime/vm/clustered_snapshot.h ('k') | runtime/vm/snapshot.h » ('j') | runtime/vm/snapshot.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698