Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: chrome/browser/ui/cocoa/menu_button.mm

Issue 2859903003: [Mac] App Menu Animated Icon (Closed)
Patch Set: Switch to CanvasSkiaPaint Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/menu_button.h ('k') | chrome/browser/ui/cocoa/toolbar/app_toolbar_button.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/menu_button.mm
diff --git a/chrome/browser/ui/cocoa/menu_button.mm b/chrome/browser/ui/cocoa/menu_button.mm
index 15ffcab3c8d1a1285bcd3312731e5c78af7b15ad..9e79a212bb40c8071fbe41bc3470c0747c901e14 100644
--- a/chrome/browser/ui/cocoa/menu_button.mm
+++ b/chrome/browser/ui/cocoa/menu_button.mm
@@ -94,6 +94,10 @@
return [self bounds];
}
+- (void)willShowMenu {
+ // Subclasses should implement this, but it's not necessary.
+}
+
@end // @implementation MenuButton
@implementation MenuButton (Private)
@@ -179,6 +183,7 @@
pullsDown:YES]);
}
DCHECK(popUpCell_.get());
+ [self willShowMenu];
[popUpCell_ setMenu:[self attachedMenu]];
[popUpCell_ selectItem:nil];
[popUpCell_ attachPopUpWithFrame:frame inView:self];
« no previous file with comments | « chrome/browser/ui/cocoa/menu_button.h ('k') | chrome/browser/ui/cocoa/toolbar/app_toolbar_button.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698