Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2859833003: [infra] Prepare gn.py for update to GN binary (Closed)

Created:
3 years, 7 months ago by zra
Modified:
3 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[infra] Prepare gn.py for update to GN binary First part in attempt to reland https://codereview.chromium.org/2854583002/ in two parts. If the second part fails, this part does not need to be reverted. Committed: https://github.com/dart-lang/sdk/commit/c94667420a09020f0a810c069cdf899ce60ed2e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/gn.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
zra
TBR
3 years, 7 months ago (2017-05-03 22:23:30 UTC) #2
zra
Committed patchset #1 (id:1) manually as c94667420a09020f0a810c069cdf899ce60ed2e7 (presubmit successful).
3 years, 7 months ago (2017-05-03 22:23:46 UTC) #4
siva
Not sure how this was running before with cpu count > 1
3 years, 7 months ago (2017-05-04 05:14:32 UTC) #5
zra
On 2017/05/04 05:14:32, siva wrote: > Not sure how this was running before with cpu ...
3 years, 7 months ago (2017-05-04 05:28:53 UTC) #6
siva
3 years, 7 months ago (2017-05-04 05:29:46 UTC) #7
Message was sent while issue was closed.
On 2017/05/04 05:28:53, zra wrote:
> On 2017/05/04 05:14:32, siva wrote:
> > Not sure how this was running before with cpu count > 1
> 
> The newer version of GN being used by Fuchsia and Flutter was encountering
> problems on the bots. I scaled this back to eliminate a possible source of the
> problems, but it didn't help. This can probably be returned to the original
> value, but I want to wait to do that until the update lands.

Sounds good.

Powered by Google App Engine
This is Rietveld 408576698