Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: chrome/browser/subresource_filter/subresource_filter_content_settings_manager.h

Issue 2859783002: [subresource_filter] Make website setting existence imply site activation (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/subresource_filter/subresource_filter_content_settings_manager.h
diff --git a/chrome/browser/subresource_filter/subresource_filter_content_settings_manager.h b/chrome/browser/subresource_filter/subresource_filter_content_settings_manager.h
index 31be4339d800a757cc79792664cdc713d1e1872d..8f55ef631d9218f5c5f0f2ecc09df845a09a2e1c 100644
--- a/chrome/browser/subresource_filter/subresource_filter_content_settings_manager.h
+++ b/chrome/browser/subresource_filter/subresource_filter_content_settings_manager.h
@@ -48,11 +48,16 @@ class SubresourceFilterContentSettingsManager
// the content setting to turn off the subresource filter.
void WhitelistSite(const GURL& url);
+ // Public for testing.
+ std::unique_ptr<base::DictionaryValue> GetSiteMetadata(const GURL& url) const;
+
// Specific logic for more intelligent UI.
void OnDidShowUI(const GURL& url);
bool ShouldShowUIForSite(const GURL& url) const;
bool should_use_smart_ui() const { return should_use_smart_ui_; }
+ void ClearSiteMetadata(const GURL& url);
+
void set_clock_for_testing(std::unique_ptr<base::Clock> tick_clock) {
clock_ = std::move(tick_clock);
}
@@ -76,7 +81,6 @@ class SubresourceFilterContentSettingsManager
const history::URLRows& deleted_rows,
const std::set<GURL>& favicon_urls) override;
- std::unique_ptr<base::DictionaryValue> GetSiteMetadata(const GURL& url) const;
void SetSiteMetadata(const GURL& url,
std::unique_ptr<base::DictionaryValue> dict);

Powered by Google App Engine
This is Rietveld 408576698