[subresource_filter] Make website setting existence imply site activation

components/subresource_filter/content/browser/fake_safe_browsing_database_manager.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/logging.h"
 #include "content/public/browser/browser_thread.h"
 #include "url/gurl.h"
 
 FakeSafeBrowsingDatabaseManager::FakeSafeBrowsingDatabaseManager()
     : simulate_timeout_(false) {}
 
 void FakeSafeBrowsingDatabaseManager::AddBlacklistedUrl(
     const GURL& url,
     safe_browsing::SBThreatType threat_type) {
   url_to_threat_type_[url] = threat_type;
 }
 
+void FakeSafeBrowsingDatabaseManager::RemoveBlacklistedUrl(const GURL& url) {
+  url_to_threat_type_.erase(url);
+}
+
 void FakeSafeBrowsingDatabaseManager::SimulateTimeout() {
   simulate_timeout_ = true;
 }
 
 FakeSafeBrowsingDatabaseManager::~FakeSafeBrowsingDatabaseManager() {}
 
 bool FakeSafeBrowsingDatabaseManager::CheckUrlForSubresourceFilter(
     const GURL& url,
     Client* client) {
   if (simulate_timeout_)
@@ skipping 14 matching lines @@
 }
 
 void FakeSafeBrowsingDatabaseManager::OnCheckUrlForSubresourceFilterComplete(
     Client* client,
     const GURL& url) {
   // Check to see if the request was cancelled to avoid use-after-free.
   if (checks_.find(client) == checks_.end())
     return;
   client->OnCheckBrowseUrlResult(url, url_to_threat_type_[url],
                                  safe_browsing::ThreatMetadata());
+  // Erase the client when a check is complete. Otherwise, it's possible
+  // subsequent clients that share an address with this one will DCHECK in
+  // CheckUrlForSubresourceFilter.
+  checks_.erase(client);
 }
 
 bool FakeSafeBrowsingDatabaseManager::CheckResourceUrl(const GURL& url,
                                                        Client* client) {
   return true;
 }
 
 bool FakeSafeBrowsingDatabaseManager::IsSupported() const {
   return true;
 }
@@ skipping 11 matching lines @@
 safe_browsing::ThreatSource FakeSafeBrowsingDatabaseManager::GetThreatSource()
     const {
   return safe_browsing::ThreatSource::LOCAL_PVER4;
 }
 
 bool FakeSafeBrowsingDatabaseManager::CheckExtensionIDs(
     const std::set<std::string>& extension_ids,
     Client* client) {
   return true;
 }