fix #29544, mixins to a class with named constructors

fix #29544, mixins to a class with named constructors

R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/171f7ba59277a7a8defd91c257afca3de88e24fe

[Jennifer Messerly, 2017-05-03 18:23:58]

Patchset #1 (id:1) has been deleted

[Jennifer Messerly, 2017-05-03 18:24:05]

Patchset #1 (id:20001) has been deleted

[Jennifer Messerly, 2017-05-03 18:24:58]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2017-05-03 18:24:59]

Here's the fix ... Note this depends on the change that enabled a bunch of
tests, which can be found at https://codereview.chromium.org/2861783002/ ...
thank you!

[Jennifer Messerly, 2017-05-03 19:43:55]

https://codereview.chromium.org/2859703003/diff/30001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart (right):

https://codereview.chromium.org/2859703003/diff/30001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart:46: if
($base[$_namedConstructors] != null) {
Just noticed while working on another CL: this should use `safeGetOwnProperty`
instead of [], because we only want to look at base.

Same thing below in defineNamedConstructor. I'll work on fixing those if it all
looks good to you, and add a test for the problematic case.

[vsm, 2017-05-04 14:32:52]

lgtm

[Jennifer Messerly, 2017-05-04 19:33:54]

Description was changed from

==========
fix #29544, mixins to a class with named constructors
==========

to

==========
fix #29544, mixins to a class with named constructors

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/171f7ba59277a7a8defd91c257afca3de88e24fe
==========

[Jennifer Messerly, 2017-05-04 19:33:55]

Committed patchset #2 (id:40001) manually as
171f7ba59277a7a8defd91c257afca3de88e24fe (presubmit successful).