third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win_unittest.py - Issue 2859703002: webkitpy: Override TEMPDIR for Xvfb.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win_unittest.py

Issue 2859703002: webkitpy: Override TEMPDIR for Xvfb. (Closed)

Patch Set: track mock call env, add test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win_unittest.py

index 25c426643b995dd42b4222a873b7a1d3a15261da..ac22f99b88884667caa2376745407b36d3a74b35 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win_unittest.py

@@ -70,7 +70,7 @@ class TestDumpReaderWin(unittest.TestCase):

dump_reader = DumpReaderWin(host, build_dir)

self.assertTrue(dump_reader.check_is_functional())

- host.executive.calls = []

+ host.executive.full_calls = []

self.assertEqual("MOCK output of child process", dump_reader._get_stack_from_dump(dump_file))

self.assertEqual(1, len(host.executive.calls))

cmd_line = " ".join(host.executive.calls[0])