Filter redundant JumpList favicons' fetching and related

chrome/browser/win/jumplist.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_WIN_JUMPLIST_H_
 #define CHROME_BROWSER_WIN_JUMPLIST_H_
 
 #include <stddef.h>
 
 #include <list>
@@ skipping 84 matching lines @@
     // has new updates therefore its icons need to be updated.
     // By default, this flag is set to false. If there's any change in TopSites
     // service, this flag will be set to true.
     bool recently_closed_pages_have_updates_ = false;
   };
 
   // Observer callback for TabRestoreService::Observer to notify when a tab is
   // added or removed.
   void TabRestoreServiceChanged(sessions::TabRestoreService* service) override;
 
+  // Called on a timer to update the "Recently Closed" category of JumpList

[grt (UTC plus 2), 2017/05/04 11:32:43]

nit: it's generally nice to group overrides together based on the originating
class. please move this method declaration (and its defn in the .cc file) so
that it isn't sandwiched between these overrides. also, it should be private if
possible. maybe put it down near DeferredTopSitesChanged.

[chengx, 2017/05/04 20:48:04]

Done.

+  // after requests storms have subsided.
+  void DeferredTabRestoreServiceChanged();
+
   // Observer callback to notice when our associated TabRestoreService
   // is destroyed.
   void TabRestoreServiceDestroyed(
       sessions::TabRestoreService* service) override;
 
   // Cancel a pending jumplist update.
   void CancelPendingUpdate();
 
   // Terminate the jumplist: cancel any pending updates and stop observing
   // the Profile and its services. This must be called before the |profile_|
@@ skipping 33 matching lines @@
   // decompresses collected favicons and updates a JumpList.
   void StartLoadingFavicon();
 
   // A callback function for HistoryService that notify when a requested favicon
   // is available.
   // To avoid file operations, this function just attaches the given data to
   // a ShellLinkItem object.
   void OnFaviconDataAvailable(
       const favicon_base::FaviconImageResult& image_result);
 
-  // Callback for TopSites that notifies when the "Most
-  // Visited" list is available. This function updates the ShellLinkItemList
-  // objects and send another query that retrieves a favicon for each URL in
-  // the list.
+  // Callback for TopSites that notifies when the "Most Visited" list is
+  // available. This function updates the ShellLinkItemList objects and sen

[grt (UTC plus 2), 2017/05/04 11:32:43]

"...and sen" -> "...and begins the process of fetching favicons for the URLs."
or something like that

[chengx, 2017/05/04 20:48:04]

Done.

+  // another query that retrieves a favicon for each URL in the list.
   void OnMostVisitedURLsAvailable(
       const history::MostVisitedURLList& data);
 
   // Callback for changes to the incognito mode availability pref.
   void OnIncognitoAvailabilityChanged();
 
-  // Helper for RunUpdate() that determines its parameters.
+  // Posts tasks to update the JumpList and delete any obsolete JumpList related
+  // folders.
   void PostRunUpdate();
 
-  // Called on a timer to invoke RunUpdateJumpList() after
-  // requests storms have subsided.
-  void DeferredRunUpdate();
-
   // history::TopSitesObserver implementation.
   void TopSitesLoaded(history::TopSites* top_sites) override;
   void TopSitesChanged(history::TopSites* top_sites,
                        ChangeReason change_reason) override;
 
+  // Called on a timer to update the most visited URLs after requests storms
+  // have subsided.
+  void DeferredTopSitesChanged();
+
   // Tracks FaviconService tasks.
   base::CancelableTaskTracker cancelable_task_tracker_;
 
   // The Profile object is used to listen for events
   Profile* profile_;
 
   // Lives on the UI thread.
   std::unique_ptr<PrefChangeRegistrar> pref_change_registrar_;
 
   // App id to associate with the jump list.
   std::wstring app_id_;
 
   // The directory which contains JumpList icons.
   base::FilePath icon_dir_;
 
-  // Timer for requesting delayed updates of the jumplist.
-  base::OneShotTimer timer_;
+  // Timer for requesting delayed updates of the "Most Visited" category of
+  // jumplist.
+  base::OneShotTimer timer_most_visited_;
+
+  // Timer for requesting delayed updates of the "Recently Closed" category of
+  // jumplist.
+  base::OneShotTimer timer_recently_closed_;
 
   // Holds data that can be accessed from multiple threads.
   scoped_refptr<base::RefCountedData<JumpListData>> jumplist_data_;
 
   // Id of last favicon task. It's used to cancel current task if a new one
   // comes in before it finishes.
   base::CancelableTaskTracker::TaskId task_id_;
 
   // A task runner running tasks to update the JumpList.
   scoped_refptr<base::SingleThreadTaskRunner> update_jumplist_task_runner_;
 
   // A task runner running tasks to delete JumpListIcons directory and
   // JumpListIconsOld directory.
   scoped_refptr<base::SequencedTaskRunner> delete_jumplisticons_task_runner_;
 
   // For callbacks may be run after destruction.
   base::WeakPtrFactory<JumpList> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(JumpList);
 };
 
 #endif  // CHROME_BROWSER_WIN_JUMPLIST_H_