Pass type argument vector to generic functions (if --reify-generic-functions is

runtime/vm/flow_graph_inliner.cc

Index: runtime/vm/flow_graph_inliner.cc
diff --git a/runtime/vm/flow_graph_inliner.cc b/runtime/vm/flow_graph_inliner.cc
index 8f8eeecc88ec002fa95f244265c36c327e2e5c79..721b3308c20b1d3f6ec48410dc52a80257866a35 100644
--- a/runtime/vm/flow_graph_inliner.cc
+++ b/runtime/vm/flow_graph_inliner.cc
@@ -863,6 +863,7 @@ class CallSiteInliner : public ValueObject {
 
         // After treating optional parameters the actual/formal count must
         // match.
+        // TODO(regis): Consider type arguments in arguments.

[Vyacheslav Egorov (Google), 2017/05/13 22:20:14]

maybe also add 

if (function.IsGeneric()) return false;

for now to avoid hitting assertions / breaking inliner?

[regis, 2017/05/18 21:02:12]

I suspect that many generic functions of the sdk get inlined. They are currently
called without type arguments. I prefer to return only if type arguments are
passed. I already started to work on the inliner in another cl.

         ASSERT(arguments->length() == function.NumParameters());
         ASSERT(param_stubs->length() == callee_graph->parameter_count());
 
@@ -1341,6 +1342,7 @@ class CallSiteInliner : public ValueObject {
     ASSERT(!function.HasOptionalPositionalParameters() ||
            !function.HasOptionalNamedParameters());
 
+    // TODO(regis): Consider type arguments in arguments.
     intptr_t arg_count = arguments->length();
     intptr_t param_count = function.NumParameters();
     intptr_t fixed_param_count = function.num_fixed_parameters();